Skip to content

Commit

Permalink
CI: fix CI scripts to fail if a command fails.
Browse files Browse the repository at this point in the history
If compilation failed, we didn't stop (though except for fuzzing, we
would fail when we try to run the tests).

Also use make -s instead of redirecting make ooutput.

Signed-off-by: Rusty Russell <[email protected]>
  • Loading branch information
rustyrussell authored and niftynei committed Jul 25, 2022
1 parent 8f6afed commit d0c321b
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion .github/scripts/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ export VALGRIND=${VALGRIND:-0}
export FUZZING=${FUZZING:-0}
export LIGHTNINGD_POSTGRES_NO_VACUUM=1

# Fail if any commands fail.
set -e

pip3 install --user poetry
poetry config virtualenvs.create false --local
poetry install
Expand Down Expand Up @@ -89,7 +92,7 @@ then

./configure CC="$TARGET_HOST-gcc" --enable-static

make -j32 CC="$TARGET_HOST-gcc" > /dev/null
make -s -j32 CC="$TARGET_HOST-gcc"
else
eatmydata make -j32
# shellcheck disable=SC2086
Expand Down

0 comments on commit d0c321b

Please sign in to comment.