lightningd: expose created_index and updated_index fields.

If you miss a wait event, you can catch up by doing listinvoices and getting the max of these fields. It's also a good debugging clue. Signed-off-by: Rusty Russell <[email protected]>
ddustin · Jul 23, 2023 · d25a8ca · d25a8ca
1 parent 284262d
commit d25a8ca
Show file tree

Hide file tree

Showing 27 changed files with 559 additions and 325 deletions.
diff --git a/.msggen.json b/.msggen.json
@@ -368,6 +368,7 @@
             "CreateInvoice.amount_received_msat": 10,
             "CreateInvoice.bolt11": 2,
             "CreateInvoice.bolt12": 3,
+            "CreateInvoice.created_index": 16,
             "CreateInvoice.description": 7,
             "CreateInvoice.expires_at": 8,
             "CreateInvoice.invreq_payer_note": 15,
@@ -574,14 +575,16 @@
             "DelInvoice.amount_msat": 4,
             "DelInvoice.bolt11": 2,
             "DelInvoice.bolt12": 3,
+            "DelInvoice.created_index": 12,
             "DelInvoice.description": 5,
             "DelInvoice.expires_at": 8,
             "DelInvoice.invreq_payer_note": 11,
             "DelInvoice.label": 1,
             "DelInvoice.local_offer_id": 9,
             "DelInvoice.payer_note": 10,
             "DelInvoice.payment_hash": 6,
-            "DelInvoice.status": 7
+            "DelInvoice.status": 7,
+            "DelInvoice.updated_index": 13
         },
         "DisconnectRequest": {
             "Disconnect.force": 2,
@@ -764,6 +767,7 @@
         },
         "InvoiceResponse": {
             "Invoice.bolt11": 1,
+            "Invoice.created_index": 10,
             "Invoice.expires_at": 4,
             "Invoice.payment_hash": 2,
             "Invoice.payment_secret": 3,
@@ -926,6 +930,7 @@
             "ListInvoices.invoices[].amount_received_msat": 12,
             "ListInvoices.invoices[].bolt11": 7,
             "ListInvoices.invoices[].bolt12": 8,
+            "ListInvoices.invoices[].created_index": 16,
             "ListInvoices.invoices[].description": 2,
             "ListInvoices.invoices[].expires_at": 5,
             "ListInvoices.invoices[].invreq_payer_note": 15,
@@ -936,7 +941,8 @@
             "ListInvoices.invoices[].payer_note": 10,
             "ListInvoices.invoices[].payment_hash": 3,
             "ListInvoices.invoices[].payment_preimage": 14,
-            "ListInvoices.invoices[].status": 4
+            "ListInvoices.invoices[].status": 4,
+            "ListInvoices.invoices[].updated_index": 17
         },
         "ListinvoicesRequest": {
             "ListInvoices.index": 5,
@@ -1513,14 +1519,16 @@
             "WaitAnyInvoice.amount_received_msat": 10,
             "WaitAnyInvoice.bolt11": 7,
             "WaitAnyInvoice.bolt12": 8,
+            "WaitAnyInvoice.created_index": 13,
             "WaitAnyInvoice.description": 2,
             "WaitAnyInvoice.expires_at": 5,
             "WaitAnyInvoice.label": 1,
             "WaitAnyInvoice.paid_at": 11,
             "WaitAnyInvoice.pay_index": 9,
             "WaitAnyInvoice.payment_hash": 3,
             "WaitAnyInvoice.payment_preimage": 12,
-            "WaitAnyInvoice.status": 4
+            "WaitAnyInvoice.status": 4,
+            "WaitAnyInvoice.updated_index": 14
         },
         "WaitinvoiceRequest": {
             "WaitInvoice.label": 1
@@ -1530,14 +1538,16 @@
             "WaitInvoice.amount_received_msat": 10,
             "WaitInvoice.bolt11": 7,
             "WaitInvoice.bolt12": 8,
+            "WaitInvoice.created_index": 13,
             "WaitInvoice.description": 2,
             "WaitInvoice.expires_at": 5,
             "WaitInvoice.label": 1,
             "WaitInvoice.paid_at": 11,
             "WaitInvoice.pay_index": 9,
             "WaitInvoice.payment_hash": 3,
             "WaitInvoice.payment_preimage": 12,
-            "WaitInvoice.status": 4
+            "WaitInvoice.status": 4,
+            "WaitInvoice.updated_index": 14
         },
         "WaitsendpayRequest": {
             "WaitSendPay.groupid": 4,
@@ -1727,6 +1737,10 @@
             "added": "pre-v0.10.1",
             "deprecated": false
         },
+        "CreateInvoice.created_index": {
+            "added": "v23.08",
+            "deprecated": false
+        },
         "CreateInvoice.description": {
             "added": "pre-v0.10.1",
             "deprecated": false
@@ -2483,6 +2497,10 @@
             "added": "pre-v0.10.1",
             "deprecated": false
         },
+        "DelInvoice.created_index": {
+            "added": "v23.08",
+            "deprecated": false
+        },
         "DelInvoice.desconly": {
             "added": "pre-v0.10.1",
             "deprecated": false
@@ -2515,6 +2533,10 @@
             "added": "pre-v0.10.1",
             "deprecated": false
         },
+        "DelInvoice.updated_index": {
+            "added": "v23.08",
+            "deprecated": false
+        },
         "Disconnect": {
             "added": "pre-v0.10.1",
             "deprecated": null
@@ -3039,6 +3061,10 @@
             "added": "pre-v0.10.1",
             "deprecated": false
         },
+        "Invoice.created_index": {
+            "added": "v23.08",
+            "deprecated": false
+        },
         "Invoice.deschashonly": {
             "added": "pre-v0.10.1",
             "deprecated": false
@@ -3579,6 +3605,10 @@
             "added": "pre-v0.10.1",
             "deprecated": false
         },
+        "ListInvoices.invoices[].created_index": {
+            "added": "v23.08",
+            "deprecated": false
+        },
         "ListInvoices.invoices[].description": {
             "added": "pre-v0.10.1",
             "deprecated": false
@@ -3619,6 +3649,10 @@
             "added": "pre-v0.10.1",
             "deprecated": false
         },
+        "ListInvoices.invoices[].updated_index": {
+            "added": "v23.08",
+            "deprecated": false
+        },
         "ListInvoices.invstring": {
             "added": "pre-v0.10.1",
             "deprecated": false
@@ -5315,6 +5349,10 @@
             "added": "pre-v0.10.1",
             "deprecated": false
         },
+        "WaitAnyInvoice.created_index": {
+            "added": "v23.08",
+            "deprecated": false
+        },
         "WaitAnyInvoice.description": {
             "added": "pre-v0.10.1",
             "deprecated": false
@@ -5355,6 +5393,10 @@
             "added": "pre-v0.10.1",
             "deprecated": false
         },
+        "WaitAnyInvoice.updated_index": {
+            "added": "v23.08",
+            "deprecated": false
+        },
         "WaitInvoice": {
             "added": "pre-v0.10.1",
             "deprecated": null
@@ -5375,6 +5417,10 @@
             "added": "pre-v0.10.1",
             "deprecated": false
         },
+        "WaitInvoice.created_index": {
+            "added": "v23.08",
+            "deprecated": false
+        },
         "WaitInvoice.description": {
             "added": "pre-v0.10.1",
             "deprecated": false
@@ -5407,6 +5453,10 @@
             "added": "pre-v0.10.1",
             "deprecated": false
         },
+        "WaitInvoice.updated_index": {
+            "added": "v23.08",
+            "deprecated": false
+        },
         "WaitSendPay": {
             "added": "pre-v0.10.1",
             "deprecated": null

diff --git a/cln-grpc/proto/node.proto b/cln-grpc/proto/node.proto
diff --git a/cln-grpc/src/convert.rs b/cln-grpc/src/convert.rs
diff --git a/cln-rpc/src/model.rs b/cln-rpc/src/model.rs
diff --git a/contrib/pyln-grpc-proto/pyln/grpc/node_pb2.py b/contrib/pyln-grpc-proto/pyln/grpc/node_pb2.py