Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

legacy: Fix invalid signature on user key verify #2842

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

victorgcramos
Copy link
Member

Closes #2841

This diff fixes an annoying bug constantly reported on support channel (here's an example), where new keys were generated on GUI before sending them to the server, leading to the following error message:

2841-invalid-signature-idenitit

This issue gets fixed by updating user keys only when the /user/key request succeeds.

How to test on dev environment
  1. Create a new user: pictl usernew [email protected] test password --verify
  2. login
  3. go to Account > Identity
  4. open the network panel on your browser to get the verificationtoken
  5. Click on the "Create new identity" button
  6. write down the verificationtoken (on production mode, the verification token will be sent to user's email).
  7. Create another identity (you can do that multiple times)
  8. Navigate to /user/key/verify?verificationtoken=<your-verificationtoken>
  9. Done! (on current master, that's when the bug happens).

@victorgcramos victorgcramos marked this pull request as ready for review August 5, 2022 18:50
Copy link
Member

@tiagoalvesdulce tiagoalvesdulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

Copy link
Member

@tiagoalvesdulce tiagoalvesdulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@tiagoalvesdulce tiagoalvesdulce merged commit ccd084b into decred:master Aug 8, 2022
@victorgcramos victorgcramos added the app:legacy Issue related to legacy politeia app, prior to plugin architecture. label Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:legacy Issue related to legacy politeia app, prior to plugin architecture.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid signature when updating identity.
2 participants