Skip to content

Commit

Permalink
video: fbdev: cirrusfb: Fix kernel-doc and set but not used warnings
Browse files Browse the repository at this point in the history
Fix warnings:
- drop kernel-doc for the two debug functions to avoid the warnings
- delete unused code

v2:
  - Updated subject (Lee)

Signed-off-by: Sam Ravnborg <[email protected]>
Acked-by: Thomas Zimmermann <[email protected]>
Cc: Thomas Zimemrmann <[email protected]>
Cc: Sam Ravnborg <[email protected]>
Cc: "Gustavo A. R. Silva" <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: Saeed Mirzamohammadi <[email protected]>
Cc: Jani Nikula <[email protected]>
Cc: Mike Rapoport <[email protected]>
Cc: Lee Jones <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
  • Loading branch information
sravnborg committed Dec 5, 2020
1 parent 5a15468 commit 630a159
Showing 1 changed file with 9 additions and 11 deletions.
20 changes: 9 additions & 11 deletions drivers/video/fbdev/cirrusfb.c
Original file line number Diff line number Diff line change
Expand Up @@ -2463,8 +2463,6 @@ static void AttrOn(const struct cirrusfb_info *cinfo)
*/
static void WHDR(const struct cirrusfb_info *cinfo, unsigned char val)
{
unsigned char dummy;

if (is_laguna(cinfo))
return;
if (cinfo->btype == BT_PICASSO) {
Expand All @@ -2473,26 +2471,26 @@ static void WHDR(const struct cirrusfb_info *cinfo, unsigned char val)
WGen(cinfo, VGA_PEL_MSK, 0x00);
udelay(200);
/* next read dummy from pixel address (3c8) */
dummy = RGen(cinfo, VGA_PEL_IW);
RGen(cinfo, VGA_PEL_IW);
udelay(200);
}
/* now do the usual stuff to access the HDR */

dummy = RGen(cinfo, VGA_PEL_MSK);
RGen(cinfo, VGA_PEL_MSK);
udelay(200);
dummy = RGen(cinfo, VGA_PEL_MSK);
RGen(cinfo, VGA_PEL_MSK);
udelay(200);
dummy = RGen(cinfo, VGA_PEL_MSK);
RGen(cinfo, VGA_PEL_MSK);
udelay(200);
dummy = RGen(cinfo, VGA_PEL_MSK);
RGen(cinfo, VGA_PEL_MSK);
udelay(200);

WGen(cinfo, VGA_PEL_MSK, val);
udelay(200);

if (cinfo->btype == BT_PICASSO) {
/* now first reset HDR access counter */
dummy = RGen(cinfo, VGA_PEL_IW);
RGen(cinfo, VGA_PEL_IW);
udelay(200);

/* and at the end, restore the mask value */
Expand Down Expand Up @@ -2800,9 +2798,9 @@ static void bestclock(long freq, int *nom, int *den, int *div)

#ifdef CIRRUSFB_DEBUG

/**
/*
* cirrusfb_dbg_print_regs
* @base: If using newmmio, the newmmio base address, otherwise %NULL
* @regbase: If using newmmio, the newmmio base address, otherwise %NULL
* @reg_class: type of registers to read: %CRT, or %SEQ
*
* DESCRIPTION:
Expand Down Expand Up @@ -2847,7 +2845,7 @@ static void cirrusfb_dbg_print_regs(struct fb_info *info,
va_end(list);
}

/**
/*
* cirrusfb_dbg_reg_dump
* @base: If using newmmio, the newmmio base address, otherwise %NULL
*
Expand Down

0 comments on commit 630a159

Please sign in to comment.