Skip to content

Commit

Permalink
drm/msm/disp: Tweak display snapshot to match gpu snapshot
Browse files Browse the repository at this point in the history
Add UTS_RELEASE and show timestamp the same way for consistency.

Signed-off-by: Rob Clark <[email protected]>
Reviewed-by: Dmitry Baryshkov <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Dmitry Baryshkov <[email protected]>
Signed-off-by: Rob Clark <[email protected]>
  • Loading branch information
robclark committed Dec 15, 2021
1 parent 8ecfef9 commit 857548c
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
4 changes: 2 additions & 2 deletions drivers/gpu/drm/msm/disp/msm_disp_snapshot.h
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
* @dev: device pointer
* @drm_dev: drm device pointer
* @atomic_state: atomic state duplicated at the time of the error
* @timestamp: timestamp at which the coredump was captured
* @time: timestamp at which the coredump was captured
*/
struct msm_disp_state {
struct device *dev;
Expand All @@ -49,7 +49,7 @@ struct msm_disp_state {

struct drm_atomic_state *atomic_state;

ktime_t timestamp;
struct timespec64 time;
};

/**
Expand Down
9 changes: 6 additions & 3 deletions drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@

#define pr_fmt(fmt) "[drm:%s:%d] " fmt, __func__, __LINE__

#include <generated/utsrelease.h>

#include "msm_disp_snapshot.h"

static void msm_disp_state_dump_regs(u32 **reg, u32 aligned_len, void __iomem *base_addr)
Expand Down Expand Up @@ -79,10 +81,11 @@ void msm_disp_state_print(struct msm_disp_state *state, struct drm_printer *p)
}

drm_printf(p, "---\n");

drm_printf(p, "kernel: " UTS_RELEASE "\n");
drm_printf(p, "module: " KBUILD_MODNAME "\n");
drm_printf(p, "dpu devcoredump\n");
drm_printf(p, "timestamp %lld\n", ktime_to_ns(state->timestamp));
drm_printf(p, "time: %lld.%09ld\n",
state->time.tv_sec, state->time.tv_nsec);

list_for_each_entry_safe(block, tmp, &state->blocks, node) {
drm_printf(p, "====================%s================\n", block->name);
Expand All @@ -100,7 +103,7 @@ static void msm_disp_capture_atomic_state(struct msm_disp_state *disp_state)
struct drm_device *ddev;
struct drm_modeset_acquire_ctx ctx;

disp_state->timestamp = ktime_get();
ktime_get_real_ts64(&disp_state->time);

ddev = disp_state->drm_dev;

Expand Down

0 comments on commit 857548c

Please sign in to comment.