Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added gRPC client/server and restructured project #1

Merged
merged 1 commit into from
Dec 3, 2020
Merged

Added gRPC client/server and restructured project #1

merged 1 commit into from
Dec 3, 2020

Conversation

pierluca
Copy link
Contributor

@pierluca pierluca commented Dec 3, 2020

  • Separated concerns in different sub-packages
  • Added Makefile
  • Created client and server executables
  • Moved existing algorithm validation in testing function
  • Updated dependencies

Missing:

  • Add gRPC to ask server for database length (instead of using a constant)
  • Move to something more efficient than string-encoding for big ints (neither bytes nor int64 work!)
  • You probably don't want to use the BigZero and BigOne variables because they're not constants and bugs can alter them

@pierluca
Added gRPC client/server and restructured project
4bd2c55 
- Separated concerns in different sub-packages
- Added Makefile
- Created client and server executables
- Moved existing algorithm validation in testing function
- Updated dependencies
@pierluca pierluca requested a review from si-co December 3, 2020 00:13
@si-co si-co merged commit cb5fcd9 into main Dec 3, 2020
@nikirill nikirill deleted the grpc-and-structure branch March 3, 2021 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@si-co si-co Awaiting requested review from si-co

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pierluca @si-co