Skip to content

Commit

Permalink
Merge pull request crossplane#4309 from sttts/patch-1
Browse files Browse the repository at this point in the history
guide-observability.md: don't record events on noops
  • Loading branch information
negz authored Jul 11, 2023
2 parents 1ff5d12 + 9b22c22 commit 5d64ca5
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions contributing/guide-observability.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ Events should be recorded in the following cases:
* The state of a resource is changed
* An error occurs

Events should *not* be recorded if nothing happens or changes, with the exception
of repeated errors.

The events recorded in these cases can be thought of as forming an event log of
things that happen for the resources that Crossplane manages. Each event should
refer back to the relevant controller and resource, and use other fields of the
Expand Down

0 comments on commit 5d64ca5

Please sign in to comment.