Merge pull request flutter#2410 from eseidelGoogle/clang_warning

Add explicit destructor to appease clang plugin
deepankarsharma · Feb 19, 2016 · 60d07a7 · 60d07a7
2 parents 20d6b86 + f94ca77
commit 60d07a7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/sky/shell/ui/flutter_font_selector.cc b/sky/shell/ui/flutter_font_selector.cc
@@ -54,6 +54,9 @@ FlutterFontSelector::~FlutterFontSelector() {
 FlutterFontSelector::TypefaceAsset::TypefaceAsset() {
 }
 
+FlutterFontSelector::TypefaceAsset::~TypefaceAsset() {
+}
+
 void FlutterFontSelector::parseFontManifest() {
   std::vector<uint8_t> font_manifest_data;
   if (!zip_asset_bundle_->GetAsBuffer(kFontManifestAssetPath,

diff --git a/sky/shell/ui/flutter_font_selector.h b/sky/shell/ui/flutter_font_selector.h
@@ -45,6 +45,7 @@ class FlutterFontSelector : public blink::FontSelector {
   // A Skia typeface along with a buffer holding the raw typeface asset data.
   struct TypefaceAsset {
     TypefaceAsset();
+    ~TypefaceAsset();
     RefPtr<SkTypeface> typeface;
     std::vector<uint8_t> data;
   };