Skip to content

Commit

Permalink
HTML Compliance - Element <button> Descendant of <a> Element
Browse files Browse the repository at this point in the history
Error: The element button must not appear as a descendant of the a element.

Specification:
http://w3c.github.io/html/textlevel-semantics.html#the-a-element
"Allowed ARIA role attribute values: link (default - do not set), button, checkbox, radio, switch, tab or treeitem"
"The <a> element may be wrapped around entire paragraphs, lists, tables, and so forth, even entire sections, so long as there is no interactive content within (e.g., buttons or other links)."
  • Loading branch information
NOYB authored and fichtner committed Jan 3, 2018
1 parent cacaf77 commit ceb38b2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion dns/dyndns/src/www/services_dyndns.php
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@
<td><?=$dyndns['descr'];?></td>
<td>
<a href="services_dyndns_edit.php?id=<?=$i;?>" class="btn btn-default btn-xs"><span class="glyphicon glyphicon-pencil"></span></a>
<a href="#" data-id="<?=$i;?>" class="act_delete_service"><button type="button" class="btn btn-xs btn-default"><span class="fa fa-trash text-muted"></span></button></a>
<a href="#" data-id="<?=$i;?>" class="act_delete_service btn btn-xs btn-default"><i class="fa fa-trash text-muted"></i></a>
</td>
</tr>
<?php
Expand Down
2 changes: 1 addition & 1 deletion net/igmp-proxy/src/www/services_igmpproxy.php
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@
<td><?=$igmpentry['descr'];?></td>
<td>
<a href="services_igmpproxy_edit.php?id=<?=$i;?>" title="<?=gettext("Edit this IGMP entry"); ?>" class="btn btn-default btn-xs"><span class="glyphicon glyphicon-pencil"></span></a>
<a href="#" data-id="<?=$i;?>" class="act_delete_entry"><button type="button" class="btn btn-xs btn-default"><span class="fa fa-trash text-muted"></span></button></a>
<a href="#" data-id="<?=$i;?>" class="act_delete_entry btn btn-xs btn-default"><i class="fa fa-trash text-muted"></i></a>
</td>
</tr>
<?php
Expand Down

0 comments on commit ceb38b2

Please sign in to comment.