Removed unused BUNDLE_TOGGLED_KEY and calls to write it out, read it in.

Changes to be committed: modified: collect_app/src/main/java/org/odk/collect/android/activities/FormDownloadList.java modified: collect_app/src/main/java/org/odk/collect/android/activities/InstanceUploaderList.java modified: collect_app/src/main/java/org/odk/collect/android/utilities/ListViewUtils.java
delbertlegg · Dec 18, 2016 · 7cccd48 · 7cccd48
1 parent b57d656
commit 7cccd48
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 8 deletions.
diff --git a/collect_app/src/main/java/org/odk/collect/android/activities/FormDownloadList.java b/collect_app/src/main/java/org/odk/collect/android/activities/FormDownloadList.java
@@ -83,7 +83,6 @@ public class FormDownloadList extends ListActivity implements FormListDownloader
     private static final int AUTH_DIALOG = 2;
     private static final int MENU_PREFERENCES = Menu.FIRST;
 
-    private static final String BUNDLE_TOGGLED_KEY = "toggled";
     private static final String BUNDLE_SELECTED_COUNT = "selectedcount";
     private static final String BUNDLE_FORM_MAP = "formmap";
     private static final String DIALOG_TITLE = "dialogtitle";
@@ -323,8 +322,6 @@ private void downloadFormList() {
     @Override
     protected void onSaveInstanceState(Bundle outState) {
         super.onSaveInstanceState(outState);
-        // TODO: Is it safe to remove BUNDLE_TOGGLED_KEY ?
-        outState.putBoolean(BUNDLE_TOGGLED_KEY, false);
         outState.putInt(BUNDLE_SELECTED_COUNT, ListViewUtils.selectedItemCount(getListView()));
         outState.putSerializable(BUNDLE_FORM_MAP, mFormNamesAndURLs);
         outState.putString(DIALOG_TITLE, mAlertTitle);

diff --git a/collect_app/src/main/java/org/odk/collect/android/activities/InstanceUploaderList.java b/collect_app/src/main/java/org/odk/collect/android/activities/InstanceUploaderList.java
@@ -59,8 +59,6 @@ public class InstanceUploaderList extends ListActivity implements
         OnLongClickListener {
 
     private static final String BUNDLE_SELECTED_ITEMS_KEY = "selected_items";
-    private static final String BUNDLE_TOGGLED_KEY = "toggled";
-
     private static final int MENU_PREFERENCES = Menu.FIRST;
     private static final int MENU_SHOW_UNSENT = Menu.FIRST + 1;
     private static final int INSTANCE_UPLOADER = 0;
@@ -331,8 +329,6 @@ protected void onSaveInstanceState(Bundle outState) {
             selectedArray[i] = mSelected.get(i);
         }
         outState.putLongArray(BUNDLE_SELECTED_ITEMS_KEY, selectedArray);
-        // TODO: Safe to delete TOGGLED_KEY?
-        outState.putBoolean(BUNDLE_TOGGLED_KEY, false);
     }
 
     @Override

diff --git a/collect_app/src/main/java/org/odk/collect/android/utilities/ListViewUtils.java b/collect_app/src/main/java/org/odk/collect/android/utilities/ListViewUtils.java
@@ -57,5 +57,4 @@ public static void setAllToCheckedState(ListView lv, boolean check) {
             lv.setItemChecked(x, check);
         }
     }
-
 }
-Original file line number
+Diff line change
@@ Expand Up @@
                 lv.setItemChecked(x, check);
             }
         }
     }