Add/remove apps from/to Shortcuts-widget #2440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeitschlag
force-pushed
the
2406-most-recent-webxdcs-widget
branch
from
6ba0d55 to
da5599a
Compare
zeitschlag
force-pushed
the
2426-configure-widget
branch
from
2ed9f5d to
6aed757
Compare
zeitschlag
changed the title
zeitschlag
force-pushed
the
2406-most-recent-webxdcs-widget
branch
from
fab2718 to
bcb38e0
Compare
zeitschlag
force-pushed
the
2426-configure-widget
branch
2 times, most recently
from
524e07e to
617cf01
Compare
zeitschlag
force-pushed
the
2406-most-recent-webxdcs-widget
branch
from
a526b41 to
3cc17e4
Compare
zeitschlag
force-pushed
the
2426-configure-widget
branch
from
617cf01 to
f3a8e53
Compare
zeitschlag
force-pushed
the
2426-configure-widget
branch
from
f3a8e53 to
4d72725
Compare
zeitschlag
changed the title
Simon-Laux
reviewed
Dec 19, 2024
There was a problem hiding this comment.
Works, didn't look at the code.
probably not directly related to this pr: While testing usage with multiple accounts it was a bit unclear what happens. Like pinning from different account removed the previously pinned items (my user expectation would have been that it just adds it to the list of apps).
not that I forget it again
# Conflicts: # deltachat-ios/bqi.lproj/Localizable.strings # deltachat-ios/en.lproj/Localizable.strings # scripts/untranslated.xml
zeitschlag
force-pushed
the
2426-configure-widget
branch
from
4d72725 to
cc01e8e
Compare
r10s
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the Widget (#2418) configurable. The widget doesn't show the most recent apps anymore but only those handpicked by the user. To handpick the Webxdc-apps, this PR introduces some new menu-entries to the App-gallery and the menu on the Webxdc-Screen:
The ids of the selected Webxdc-apps (read: messages) and the user-account are stored as JSON in core-config using
ui.ios.selected_apps_for_widgetas key.(On another note: An alternative would've been to make the widget really configurable, so that users can pick the apps when editing the widget itself, but this approach made way more sense for our usecase, well, it made more sense to me and it was easier and more straight forward to implement than making a configurable widget)
Closes #2426.