Enabling clang::find_bad_constructs for desktop_capture.

This CL removes //build/config/clang:find_bad_constructs from the suppressed_configs list, which means that clang:find_bad_constructs is now enabled on these translation units. Bug: webrtc:9251, webrtc:163 Change-Id: I7ad7b03ae1b28fbf5712e671f361928c5e6d7a18 Reviewed-on: https://webrtc-review.googlesource.com/89384 Reviewed-by: Sergey Ulanov <[email protected]> Reviewed-by: Sergey Ulanov <[email protected]> Commit-Queue: Sergey Ulanov <[email protected]> Cr-Commit-Position: refs/heads/master@{#24047}
derek1875 · Jul 19, 2018 · a6bec58 · a6bec58
1 parent e12e68c
commit a6bec58
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/modules/desktop_capture/BUILD.gn b/modules/desktop_capture/BUILD.gn
@@ -113,10 +113,6 @@ if (rtc_include_tests) {
       ]
       deps += [ ":desktop_capture_mock" ]
     }
-    if (!build_with_chromium && is_clang) {
-      # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
-      suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
-    }
   }
 
   rtc_source_set("screen_drawer") {

diff --git a/modules/desktop_capture/screen_capturer_unittest.cc b/modules/desktop_capture/screen_capturer_unittest.cc
@@ -74,7 +74,7 @@ class FakeSharedMemory : public SharedMemory {
  public:
   FakeSharedMemory(char* buffer, size_t size)
       : SharedMemory(buffer, size, 0, kTestSharedMemoryId), buffer_(buffer) {}
-  virtual ~FakeSharedMemory() { delete[] buffer_; }
+  ~FakeSharedMemory() override { delete[] buffer_; }
 
  private:
   char* buffer_;