Apply changes after review

derkachm · May 14, 2019 · 611c2e3 · 611c2e3
1 parent c25d9b8
commit 611c2e3
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/docs/guides/payments.rst b/docs/guides/payments.rst
@@ -40,7 +40,7 @@ Example
 .. note::
 
     All the below functions receive ``payment_information`` as a dataclass: ``PaymentData`` and ``config`` as a dataclass: ``ConfigData``. 
-    Functions should return a response as a dataclass: ``GatewayResponse``. 
+    Those functions should return a response as a dataclass: ``GatewayResponse``. 
     The description of the given structures can be found below.
 
 
@@ -444,7 +444,8 @@ Please take a moment to consider the example settings above.
     List of parameters used for connecting to the payment's gateway.
 
 - ``auto_capture``
-    Define if the gateway should also capture funds from the card. When auto_capture is set to False, funds will be blocked but manual capture will be required.
+    Define if the gateway should also capture funds from the card. When ``auto_capture`` is set to ``False``, funds will be blocked by the customer's bank for a 7-days period, a manual capture will be required.
+
 
 .. note::
 

diff --git a/tests/gateway/test_braintree.py b/tests/gateway/test_braintree.py
@@ -180,7 +180,7 @@ def test_extract_gateway_response_no_transaction(
 def test_get_braintree_gateway(gateway_config):
     connection_params = gateway_config.connection_params
     result = get_braintree_gateway(**gateway_config.connection_params)
-    assert connection_params["sandbox_mode"] == False
+    assert connection_params["sandbox_mode"] is False
     assert result.config.environment == Environment.Production
     assert result.config.merchant_id == connection_params["merchant_id"]
     assert result.config.public_key == connection_params["public_key"]

diff --git a/tests/gateway/test_dummy.py b/tests/gateway/test_dummy.py
@@ -151,7 +151,10 @@ def test_capture_gateway_error(payment_txn_preauth, monkeypatch):
 
 
 @pytest.mark.parametrize(
-    "initial_captured_amount, refund_amount, final_captured_amount, final_charge_status, active_after",
+    (
+        "initial_captured_amount, refund_amount, final_captured_amount, "
+        "final_charge_status, active_after"
+    ),
     [
         (80, 80, 0, ChargeStatus.FULLY_REFUNDED, False),
         (80, 10, 70, ChargeStatus.PARTIALLY_REFUNDED, True),