Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not chunk when performing beamforming #45

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

popcornell
Copy link
Contributor

as pointed out by @kamo-naoyuki, there are currently problems when doing the beamforming due to the fact that the a-posteriori SNR reference channel selection is performed for each freq chunk independently (and this requires a reduction over the freq axis).
The easy fix is to avoid to chunk frequencies when doing the beamfoming. Hopefully it is still ok and will not lead to OOMs

@popcornell
Copy link
Contributor Author

@kamo-naoyuki, did you had a chance to try ?
For me the results are the same as with the old code. But may it be because my GPUs are 40GB VRAM.

@desh2608 can you merge ? I confirmed this does not impact the results.

@desh2608
Copy link
Owner

I am concerned that this may cause GPU OOMs when the segment is long and/or we are using a large number of channels. It may be better to have a CLI option to set bf chunking on/off (turned on by default). Could you make this change?

@popcornell
Copy link
Contributor Author

Yes but then we need to also disable the channel selection inside the beamformer when the option is disabled.

Or IDK beamforming part needs to be changed quite a lot to accomodate for chunking but only before the channel.selection

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants