Skip to content

Commit

Permalink
fix: Enable remark-lint-unordered-list-marker-style
Browse files Browse the repository at this point in the history
Upstream style uses asterisks
  • Loading branch information
nschonni committed Mar 29, 2020
1 parent 14a533d commit 8009344
Show file tree
Hide file tree
Showing 43 changed files with 509 additions and 510 deletions.
3 changes: 1 addition & 2 deletions .remarkrc
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"remark-frontmatter",
"remark-preset-lint-node",
["remark-lint-first-heading-level", false],
["remark-lint-maximum-line-length", false],
["remark-lint-unordered-list-marker-style", false]
["remark-lint-maximum-line-length", false]
]
}
38 changes: 19 additions & 19 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,62 +12,62 @@ This project follows the [Conventional Commits][] specification.

There is a built-in commit linter. Basic rules:

- Commit messages must be prefixed with the name of the changed subsystem, followed by a colon and a space and start with an imperative verb. Check the output of `git log --oneline files/you/changed` to find out what subsystems your changes touch.
* Commit messages must be prefixed with the name of the changed subsystem, followed by a colon and a space and start with an imperative verb. Check the output of `git log --oneline files/you/changed` to find out what subsystems your changes touch.

Supported subsystems:

> build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test
- Commit messages **must** start with a capital letter
- Commit messages **must not** end with a period `.`
* Commit messages **must** start with a capital letter
* Commit messages **must not** end with a period `.`

## Collaboration Policy

- All changes must come in a PR
- All changes must be reviewed by a member of @nodejs/nodejs.dev,
* All changes must come in a PR
* All changes must be reviewed by a member of @nodejs/nodejs.dev,
@nodejs/website, or @nodejs/website-redesign
- Pull Requests must be open for at least 48 hours unless included in the special exemptions section below
* Pull Requests must be open for at least 48 hours unless included in the special exemptions section below

### Special Exemptions

Pull requests seeking to make any of the following changes do not need to wait 24 hours

- Errata fixes
- Infrastructure Maintenance
- Tests
* Errata fixes
* Infrastructure Maintenance
* Tests

## Landing Pull Requests

### Before you can land

- The Status Checks for the test suite must pass
- There must be at least one sign off
- There must be no objections after a 48 hour period
* The Status Checks for the test suite must pass
* There must be at least one sign off
* There must be no objections after a 48 hour period

The default for each contribution is that it is accepted once no collaborator has an objection. During review collaborators may also request that a specific contributor who is most versed in a particular area gives a "LGTM" before the PR can be merged.

In the case of an objection being raised in a pull request by another collaborator, all involved collaborators should seek to arrive at a consensus by way of addressing concerns being expressed by discussion, compromise on the proposed change, or withdrawal of the proposed change.

## When Landing

- Do not use merge button
- [`squash`][] pull-requests made up of multiple commits
- Land how you like as long as there are no merge commits
* Do not use merge button
* [`squash`][] pull-requests made up of multiple commits
* Land how you like as long as there are no merge commits

## Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

- (a) The contribution was created in whole or in part by me and I have the right to
* (a) The contribution was created in whole or in part by me and I have the right to
submit it under the open source license indicated in the file; or
- (b) The contribution is based upon previous work that, to the best of my knowledge,
* (b) The contribution is based upon previous work that, to the best of my knowledge,
is covered under an appropriate open source license and I have the right under that
license to submit that work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am permitted to submit under a
different license), as indicated in the file; or
- (c) The contribution was provided directly to me by some other person who certified
* (c) The contribution was provided directly to me by some other person who certified
(a), (b) or (c) and I have not modified it.
- (d) I understand and agree that this project and the contribution are public and that
* (d) I understand and agree that this project and the contribution are public and that
a record of the contribution (including all personal information I submit with it,
including my sign-off) is maintained indefinitely and may be redistributed consistent
with this project or the open source license(s) involved.
Expand Down
34 changes: 17 additions & 17 deletions OKR.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,34 +6,34 @@ The Nodejs.dev project uses Objectives and Key Results to provide direction and

OKRs consist of two elements:

- Objectives
- Objectives are qualitative, ambitious, and memorable definitions of the things we as a committee would like to achieve.
- Key Results
- Key Results are a set of metrics by which we can measure progress toward their objectives. Like objectives, they should be ambitious and overestimate what we can accomplish.
* Objectives
* Objectives are qualitative, ambitious, and memorable definitions of the things we as a committee would like to achieve.
* Key Results
* Key Results are a set of metrics by which we can measure progress toward their objectives. Like objectives, they should be ambitious and overestimate what we can accomplish.

### External References

Here are some external references that may help provide further context on OKRs.

- [Guide: Set goals with OKRs](https://rework.withgoogle.com/guides/set-goals-with-okrs/steps/introduction/)
- [What is OKR?](https://felipecastro.com/en/okr/what-is-okr/)
- [What Are OKRs? How to Use OKRs for Planning (and Achieving) Your Goals](https://plan.io/blog/what-are-okrs/)
* [Guide: Set goals with OKRs](https://rework.withgoogle.com/guides/set-goals-with-okrs/steps/introduction/)
* [What is OKR?](https://felipecastro.com/en/okr/what-is-okr/)
* [What Are OKRs? How to Use OKRs for Planning (and Achieving) Your Goals](https://plan.io/blog/what-are-okrs/)

## OKRs (2020 Set 1):

- **Objective:** Continuity of process
* **Objective:** Continuity of process

- **Key Result:** Staging and CI have each have a published technical administration summary and a how-to guide.
- **Key Result:** Consider using issue templates to facilitate operations.
* **Key Result:** Staging and CI have each have a published technical administration summary and a how-to guide.
* **Key Result:** Consider using issue templates to facilitate operations.

- **Objective:** Identify areas of progress and future goals
* **Objective:** Identify areas of progress and future goals

- **Key Result:** Create a feature roadmap
- **Key Result:** Track features & priorities in one place (project?)
- **Key Result:** Make available the top two features in nodejs.org:
* **Key Result:** Create a feature roadmap
* **Key Result:** Track features & priorities in one place (project?)
* **Key Result:** Make available the top two features in nodejs.org:
1. Docs — https://nodejs.org/en/docs/
2. Download — https://nodejs.org/en/download/

- **Objective:** Make explicit the channels of interfacing internally and with larger org
- **Key Result:** Write down implicit team norms
- **Key Result:** How do we propose and review non-feature changes in PRs?
* **Objective:** Make explicit the channels of interfacing internally and with larger org
* **Key Result:** Write down implicit team norms
* **Key Result:** How do we propose and review non-feature changes in PRs?
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,9 @@ The `src/documentation` directory currently contains all the getting started con

Looking for more guidance? Full documentation for Gatsby lives [on the website](https://next.gatsbyjs.org/). Here are some places to start:

- **For most developers, we recommend starting with our [in-depth tutorial for creating a site with Gatsby](https://next.gatsbyjs.org/tutorial/).** It starts with zero assumptions about your level of ability and walks through every step of the process.
* **For most developers, we recommend starting with our [in-depth tutorial for creating a site with Gatsby](https://next.gatsbyjs.org/tutorial/).** It starts with zero assumptions about your level of ability and walks through every step of the process.

- **To dive straight into code samples head [to our documentation](https://next.gatsbyjs.org/docs/).** In particular, check out the "Guides", API reference, and "Advanced Tutorials" sections in the sidebar.
* **To dive straight into code samples head [to our documentation](https://next.gatsbyjs.org/docs/).** In particular, check out the "Guides", API reference, and "Advanced Tutorials" sections in the sidebar.

## 🏛 Governance

Expand Down
Loading

0 comments on commit 8009344

Please sign in to comment.