arch_topology: Fix putting invalid cpu clk

Add a sanity check before putting the cpu clk. Fixes: b8fe128 (“arch_topology: Adjust initial CPU capacities with current freq") Signed-off-by: Jeffy Chen <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
devinus · Mar 18, 2020 · 4dfff3d · 4dfff3d
1 parent 4a33691
commit 4dfff3d
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c
@@ -164,11 +164,11 @@ bool __init topology_parse_cpu_capacity(struct device_node *cpu_node, int cpu)
 		 * frequency (by keeping the initial freq_factor value).
 		 */
 		cpu_clk = of_clk_get(cpu_node, 0);
-		if (!PTR_ERR_OR_ZERO(cpu_clk))
+		if (!PTR_ERR_OR_ZERO(cpu_clk)) {
 			per_cpu(freq_factor, cpu) =
 				clk_get_rate(cpu_clk) / 1000;
-
-		clk_put(cpu_clk);
+			clk_put(cpu_clk);
+		}
 	} else {
 		if (raw_capacity) {
 			pr_err("cpu_capacity: missing %pOF raw capacity\n",