dmi-id: don't free dev structure after calling device_register

dmi_dev is freed in error exit code but, according to the document of device_register, it should never directly free device structure after calling this function, even if it returned an error! Use put_device() instead. Signed-off-by: Allen Hung <[email protected]> Signed-off-by: Jean Delvare <[email protected]>
devinus · Sep 8, 2016 · 9b41b92 · 9b41b92
1 parent d71f058
commit 9b41b92
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/drivers/firmware/dmi-id.c b/drivers/firmware/dmi-id.c
@@ -229,14 +229,14 @@ static int __init dmi_id_init(void)
 
 	ret = device_register(dmi_dev);
 	if (ret)
-		goto fail_free_dmi_dev;
+		goto fail_put_dmi_dev;
 
 	return 0;
 
-fail_free_dmi_dev:
-	kfree(dmi_dev);
-fail_class_unregister:
+fail_put_dmi_dev:
+	put_device(dmi_dev);
 
+fail_class_unregister:
 	class_unregister(&dmi_class);
 
 	return ret;