Skip to content

Commit

Permalink
ALSA: als4000: Fix potentially invalid DMA mode setup
Browse files Browse the repository at this point in the history
My previous patch assumed that the DMA mode (represented by 3 lowest bits of
ALS4K_GCR99_DMA_EMULATION_CTRL register) is set to the default value 0. If
that's not the case, it might result in invalid mode to be set.
This patch fixes this potential problem.

Signed-off-by: Ondrej Zary <[email protected]>
Signed-off-by: Takashi Iwai <[email protected]>
  • Loading branch information
Ondrej Zary authored and tiwai committed Aug 4, 2010
1 parent b961923 commit c468584
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sound/pci/als4000.c
Original file line number Diff line number Diff line change
Expand Up @@ -765,7 +765,7 @@ static void snd_als4000_configure(struct snd_sb *chip)
snd_als4k_gcr_write(chip, i, 0);
/* enable burst mode to prevent dropouts during high PCI bus usage */
snd_als4k_gcr_write(chip, ALS4K_GCR99_DMA_EMULATION_CTRL,
snd_als4k_gcr_read(chip, ALS4K_GCR99_DMA_EMULATION_CTRL) | 0x04);
(snd_als4k_gcr_read(chip, ALS4K_GCR99_DMA_EMULATION_CTRL) & ~0x07) | 0x04);
spin_unlock_irq(&chip->reg_lock);
}

Expand Down

0 comments on commit c468584

Please sign in to comment.