Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#195: java installation in macos #232

Closed

Conversation

mvomiero
Copy link
Contributor

Fixes: #195

CAUSE of the issue:

  • copying .ide.software.version to the target Path was failing.
    the problem was to my understanding and after my researches, that the source is a specific file path but the target is not recognized as a directory as it is, so when it tries to replace the target directory with the source file it fails.

SOLUTION:

  • adding .ide.software.version to the target Path solves the problem.
  • the file has to be copied just if it is a new installation, so it is possible to enclose it in a if statement that checks it's a new installation

COMMENTS:

  • works fine for me, but
  • still not super experienced about all the installation of commandlets. Would be nice if someone else could have a look.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8066566983

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 57.106%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/tool/LocalToolCommandlet.java 3 51.61%
Totals Coverage Status
Change from base Build 8061873366: -0.03%
Covered Lines: 3851
Relevant Lines: 6483

💛 - Coveralls

@hohwille
Copy link
Member

hohwille commented Mar 5, 2024

@mvomiero thanks for creating the bug issue, analyzing the problem and fixing it. Your PR is great. 👍
However, I merged PR #238 that also fixed the same bug so we can now close this PR.

@mvomiero mvomiero closed this Mar 5, 2024
@mvomiero mvomiero deleted the #195/java-installation-fails-in-macos branch March 5, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Installation of Java and running applications which require Java fails on Mac OS
3 participants