Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#130: Added default content length to progress bar #285

Closed
wants to merge 11 commits into from
Closed

#130: Added default content length to progress bar #285

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
cac6889
#130: add by missing content length a default value to progress bar
ndemirca Mar 27, 2024
390990e
reproduced the bug and added first fix steps
ndemirca Mar 28, 2024
14fd274
small improvements
ndemirca Mar 28, 2024
cc89f4f
set default content length
ndemirca Apr 11, 2024
0d591b1
removed empty line
ndemirca Apr 11, 2024
610c37d
renamed a method
ndemirca Apr 11, 2024
d5bdb68
added unittest to copy files
ndemirca Apr 11, 2024
d7ec4ba
added missing import and removed test file
ndemirca Apr 11, 2024
a62e3a3
Merge branch 'main' into bug/130-Add-Default-ContentLength-To-Progres…
ndemirca Apr 11, 2024
9a7b4fe
commented out unit test code piece for test purposes
ndemirca Apr 11, 2024
6752e83
commented out piece of code for test purposes
ndemirca Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
renamed a method
  • Loading branch information
@ndemirca
ndemirca committed Apr 11, 2024
commit 610c37de3fdd40c60af780c05d0b55923b682309
6 changes: 3 additions & 3 deletions cli/src/main/java/com/devonfw/tools/ide/io/FileAccessImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ public void download(String url, Path target) {
private void downloadFileWithProgressBar(String url, Path target, HttpResponse<InputStream> response) {

long contentLength = response.headers().firstValueAsLong("content-length").orElse(0);
informAboutDefaultMaxContentLength(contentLength);
informAboutSettingDefaultContentLength(contentLength);
byte[] data = new byte[1024];
boolean fileComplete = false;
int count;
Expand Down Expand Up @@ -150,7 +150,7 @@ private void copyFileWithProgressBar(Path source, Path target) throws IOExceptio
try (InputStream in = new FileInputStream(source.toFile()); OutputStream out = new FileOutputStream(target.toFile())) {

long size = source.toFile().length();
informAboutDefaultMaxContentLength(size);
informAboutSettingDefaultContentLength(size);

byte[] buf = new byte[1024];
int readBytes;
Expand All @@ -166,7 +166,7 @@ private void copyFileWithProgressBar(Path source, Path target) throws IOExceptio
}
}

private void informAboutDefaultMaxContentLength(long contentLength) {
private void informAboutSettingDefaultContentLength(long contentLength) {

if (contentLength == 0) {
this.context.warning("Content-Length was not provided by download/copy source. Using fallback: Content-Length for the progress bar is set to 10000000.");
Expand Down