Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#293: log warning instead of assertion in Step for robustness #295

Merged
merged 5 commits into from
Apr 19, 2024

Conversation

hohwille
Copy link
Member

Fixes #293:

  • Replaced the assertion that a Step that already ended should not end again with a warning
  • allow the Step to end again but avoid inconsistent transition from ERROR to SUCCESS
  • changed LocalToolCommandlet to call postInstall() before step.success

@hohwille hohwille added bugfix step Logging and monitoring of process steps labels Apr 16, 2024
@hohwille hohwille added this to the release:2024.04.001 milestone Apr 16, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8756340305

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 93 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.2%) to 59.809%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/tool/LocalToolCommandlet.java 1 77.45%
com/devonfw/tools/ide/step/Step.java 23 36.36%
com/devonfw/tools/ide/step/StepImpl.java 31 45.77%
com/devonfw/tools/ide/context/AbstractIdeContext.java 38 57.3%
Totals Coverage Status
Change from base Build 8756150707: 0.2%
Covered Lines: 4586
Relevant Lines: 7381

💛 - Coveralls

@hohwille hohwille merged commit 3b37c2c into devonfw:main Apr 19, 2024
4 checks passed
@hohwille hohwille added the story-review marks PRs that will be presented in the sprint-review label May 3, 2024
@hohwille hohwille self-assigned this May 3, 2024
@hohwille
Copy link
Member Author

hohwille commented May 3, 2024

should be reviewed together with #282

@hohwille hohwille added reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. and removed story-review marks PRs that will be presented in the sprint-review labels May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. step Logging and monitoring of process steps
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Step assertion failing on exception in postInstall()
2 participants