Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#527: fix of fix #549

Merged
merged 1 commit into from
Aug 22, 2024
Merged

#527: fix of fix #549

merged 1 commit into from
Aug 22, 2024

Conversation

hohwille
Copy link
Member

@hohwille hohwille commented Aug 20, 2024

fixes #527 (fix of fix from PR #528)

In sprint review we hit this again and I finally fixed it properly.

@hohwille hohwille added enhancement New feature or request core FileAccess, ProcessUtil, IdeContext, etc. environment EnvironmentCommandlet, env variables, path, etc. labels Aug 20, 2024
@hohwille hohwille added this to the release:2024.09.001 milestone Aug 20, 2024
@hohwille hohwille self-assigned this Aug 20, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 10473325274

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.307%

Totals Coverage Status
Change from base Build 10473219629: 0.0%
Covered Lines: 5721
Relevant Lines: 8454

💛 - Coveralls

@alfeilex alfeilex self-requested a review August 21, 2024 11:47
@hohwille
Copy link
Member Author

Since everybody is out and the fix is so trivial, I will merge now without waiting for next week for potential review.

@hohwille hohwille merged commit 58c43f0 into devonfw:main Aug 22, 2024
4 checks passed
@hohwille hohwille added the reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core FileAccess, ProcessUtil, IdeContext, etc. enhancement New feature or request environment EnvironmentCommandlet, env variables, path, etc. reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

NPE in findIdeRoot
2 participants