Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve Validation (added JavaDoc, etc.) #817

Merged
merged 3 commits into from
Nov 29, 2024
Merged

improve Validation (added JavaDoc, etc.) #817

merged 3 commits into from
Nov 29, 2024

Conversation

hohwille
Copy link
Member

ValidationResult, ValidationStatus, etc. was added in #569 but without JavaDoc.

  • added JavaDoc
  • introduce ValidationStateValid to make the code more transparent
  • make propertyName final

@hohwille hohwille added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 28, 2024
@hohwille hohwille added this to the release:2024.12.001 milestone Nov 28, 2024
@hohwille hohwille self-assigned this Nov 28, 2024
@coveralls
Copy link
Collaborator

coveralls commented Nov 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12083937370

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 70 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.005%) to 67.412%
Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/validation/ValidationState.java 2 94.59%
com/devonfw/tools/ide/context/AbstractIdeContext.java 68 60.22%
Totals Coverage Status
Change from base Build 12083932666: -0.005%
Covered Lines: 6515
Relevant Lines: 9323
💛 - Coveralls

@hohwille hohwille merged commit ae9ec5b into devonfw:main Nov 29, 2024
4 checks passed
@hohwille hohwille added the reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hohwille hohwille

Labels
documentation Improvements or additions to documentation enhancement New feature or request reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented.
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2024.12.001
Development

Successfully merging this pull request may close these issues.
2 participants
@hohwille @coveralls