Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#832: fixed tools not starting on Windows #839

Merged
merged 3 commits into from
Dec 5, 2024
Merged

#832: fixed tools not starting on Windows #839

merged 3 commits into from
Dec 5, 2024

Conversation

jan-vcapgemini
Copy link
Contributor

Fixes: #832

Implements:

  • replaced postExtract with getBinaryName for intellij, android-studio and tomcat
  • added check for background processes to finally block of ProcessContext (prevents auto destroy of tool)

@jan-vcapgemini
devonfw#832: fixed tools not starting on Windows
050bbcd 
replaced postExtract with getBinaryName for intellij, android-studio and tomcat
added check for background processes to finally block of ProcessContext (prevents auto destroy of tool)
@jan-vcapgemini jan-vcapgemini self-assigned this Dec 5, 2024
@coveralls
Copy link
Collaborator

coveralls commented Dec 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12181015491

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 48 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.3%) to 66.917%
Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/tool/tomcat/Tomcat.java 4 74.19%
com/devonfw/tools/ide/io/FileAccessImpl.java 12 61.54%
com/devonfw/tools/ide/process/ProcessContextImpl.java 14 79.87%
com/devonfw/tools/ide/tool/ToolCommandlet.java 18 64.4%
Totals Coverage Status
Change from base Build 12180969410: -0.3%
Covered Lines: 6516
Relevant Lines: 9390
💛 - Coveralls

@jan-vcapgemini jan-vcapgemini added intellij IntelliJ IDE from Jet-Brains tomcat android-studio Android Studio IDE from Jet-Brains bugfix labels Dec 5, 2024
@jan-vcapgemini jan-vcapgemini added the internal Nothing to be added to CHANGELOG, only internal story label Dec 5, 2024
hohwille
hohwille approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jan-vcapgemini thanks for your fix. Awesome work. 👍

@hohwille hohwille added this to the release:2024.12.001 milestone Dec 5, 2024
This was linked to issues Dec 5, 2024
TomcatTest fails to execute #814
Closed
Intellij does not start #766
Closed
Cannot launch IntelliJ with ìde intellij` #783
Closed
@hohwille hohwille removed a link to an issue Dec 5, 2024
Cannot launch IntelliJ with ìde intellij` #783
Closed
@hohwille hohwille merged commit 4ca0d07 into devonfw:main Dec 5, 2024
3 checks passed
@hohwille hohwille linked an issue Dec 10, 2024 that may be closed by this pull request
IDEasy not working properly in CMD #764
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hohwille hohwille hohwille approved these changes

Assignees

@jan-vcapgemini jan-vcapgemini

Labels
android-studio Android Studio IDE from Jet-Brains bugfix intellij IntelliJ IDE from Jet-Brains internal Nothing to be added to CHANGELOG, only internal story tomcat
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2024.12.001
3 participants
@jan-vcapgemini @coveralls @hohwille