Implement ContainerHash: a simple hashing structure for containers #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ContainerHash is a simple hashing algorithm for containers, based on the Boost implementation. It is useful for cases where a container is needed as a key in a hash-dependant container, such as a set or an unordered_map.
A span is to an array what a string_view is to a string. Basically, it is a lightweight and fast non-owning way to pass arrays around while conserving their length. Right now, we are using span-lite, an implementation of std::span, since the later one will be available in C++20
Also, added tests for it.
This will dramatically reduce the number of collisions.
This test uses template metaprogramming* to test BitSets of different length. In the future, it would be a good idea to update the rest of the tests to make use of this technique too. * in particular, integer sequences.
mmore500
approved these changes
Jul 16, 2020
mmore500
reviewed
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ContainerHash utilizes hash_combine to assign a unique hash to a container, allowing their use in sets and unordered_map keys.