Skip to content

Commit

Permalink
hw/i386/pc: Have pc_init_isa() pass a NULL pci_type argument
Browse files Browse the repository at this point in the history
The "isapc" machine only provides an ISA bus, not a PCI one,
and doesn't instanciate any i440FX south bridge.
Its machine class defines PCMachineClass::pci_enabled = false,
and pc_init1() only uses the pci_type argument when pci_enabled
is true. Since for this machine the argument is not used,
passing NULL makes more sense.

Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
Reviewed-by: Bernhard Beschow <[email protected]>
Message-Id: <[email protected]>
  • Loading branch information
philmd committed Mar 9, 2024
1 parent 3ac5f67 commit ecca5ca
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion hw/i386/pc_piix.c
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@ static void pc_compat_2_0_fn(MachineState *machine)
#ifdef CONFIG_ISAPC
static void pc_init_isa(MachineState *machine)
{
pc_init1(machine, TYPE_I440FX_PCI_DEVICE);
pc_init1(machine, NULL);
}
#endif

Expand Down

0 comments on commit ecca5ca

Please sign in to comment.