Skip to content

Commit

Permalink
Update CI to node v16 (cruise-automation#715)
Browse files Browse the repository at this point in the history
## Summary

The previous PR only bumped the version, but didn't change the CI config. This is now getting fixed along with the errors discovered in CI:
 - Starting npm cli v7, the user for npm run scripts changed (now this is owner of current directory: https://docs.npmjs.com/cli/v8/using-npm/scripts#user) so we need to update CircleCI script accordingly
 -  `unhandledRejection` was upgraded from Warning to Error, so we need to disable this check
 - Error messages for undefined attributes got changed
 - Couple of libraries updates



## Test plan

- Green CI. 
- Screenshots test shows  very minor differences (pixel level) so should be fine.
  • Loading branch information
pankdm authored Feb 19, 2022
1 parent 311dac2 commit 6827f18
Show file tree
Hide file tree
Showing 14 changed files with 52,214 additions and 4,520 deletions.
5 changes: 4 additions & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,10 @@ jobs:
- run: echo $REG_SUIT_EXPECTED_KEY

- run:
command: docker run -v `pwd`:`pwd` -w `pwd` -it --rm -e CI -e CIRCLE_SHA1 -e REG_SUIT_EXPECTED_KEY -e AWS_ACCESS_KEY_ID -e AWS_SECRET_ACCESS_KEY -e AWS_DEFAULT_REGION cruise/webviz-ci:0.0.13 npm run ci
# We need to explicitly chown the current directory to root running npm scripts.
# Otherwise npm will run all scripts as non-root user (see https://docs.npmjs.com/cli/v8/using-npm/scripts#user)
# which causes various permission issues
command: docker run -v `pwd`:`pwd` -w `pwd` -it --rm -e CI -e CIRCLE_SHA1 -e REG_SUIT_EXPECTED_KEY -e AWS_ACCESS_KEY_ID -e AWS_SECRET_ACCESS_KEY -e AWS_DEFAULT_REGION cruise/webviz-ci:0.0.14 /bin/bash -cx "chown -R root:root . && npm run ci"
no_output_timeout: 30m

- save_cache:
Expand Down
7 changes: 7 additions & 0 deletions .flowconfig
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,15 @@
.*\.ignore\.js
dist


[declarations]
# See https://flow.org/en/docs/config/declarations/#toc-declarations for more details.
# Preventing flow from type-checking node_modules folder (it could contain invalid files).
<PROJECT_ROOT>/node_modules/.*

[include]


[libs]
./flow-typed
./packages/webviz-core/src/globals.js.flow
Expand Down
8 changes: 8 additions & 0 deletions integration-tests/install-ffmpeg-in-docker.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,12 @@ set -euo pipefail

sed -i "s/jessie main/jessie main contrib non-free/" /etc/apt/sources.list
echo "deb [check-valid-until=no] http://archive.debian.org/debian jessie-backports main contrib non-free" >> /etc/apt/sources.list
# Adding the keys to fix the error:
# ```
# #8 2.073 W: GPG error: http://archive.debian.org/debian jessie-backports InRelease:
# The following signatures couldn't be verified because the public key is not available:
# NO_PUBKEY 8B48AD6246925553 NO_PUBKEY 7638D0442B90D010
# ```
# See also: https://askubuntu.com/a/15272
apt-key adv --keyserver keyserver.ubuntu.com --recv-keys 8B48AD6246925553 7638D0442B90D010
apt-get update && apt-get install -y ffmpeg
Loading

0 comments on commit 6827f18

Please sign in to comment.