Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: make doc without requiring nix magic #4891

Merged
merged 5 commits into from
Feb 5, 2025

Conversation

crusso
Copy link
Contributor

@crusso crusso commented Feb 5, 2025

Add a new make target that builds a documentation preview outside of nix.

Might require installation of make, node and npm if not available.

cd doc
make doc

or

make -C doc doc

@crusso crusso requested a review from rvanasa February 5, 2025 17:18
@crusso crusso marked this pull request as ready for review February 5, 2025 17:18
@crusso crusso requested a review from a team as a code owner February 5, 2025 17:18
Copy link

github-actions bot commented Feb 5, 2025

Comparing from ff64c3a to 5093ec6:
The produced WebAssembly code seems to be completely unchanged.

rvanasa
rvanasa previously approved these changes Feb 5, 2025
Copy link
Contributor

@rvanasa rvanasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crusso crusso requested review from jessiemongeon1, a team and ggreif February 5, 2025 17:30
@crusso crusso changed the title make doc without nix doc: make doc without requiring nix magic Feb 5, 2025
@crusso crusso added the automerge-squash When ready, merge (using squash) label Feb 5, 2025
@mergify mergify bot merged commit 2777991 into master Feb 5, 2025
10 checks passed
@mergify mergify bot deleted the claudio/make-doc-without-nix branch February 5, 2025 17:49
@mergify mergify bot removed the automerge-squash When ready, merge (using squash) label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants