Add exception to delimiter logic for parenthesized with syntax
#154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvanasa
changed the title
with expressionswith syntax
ggreif
reviewed
Feb 4, 2025
tests/formatter.test.ts
Outdated
| @@ -615,4 +615,11 @@ public type T = { | |||
| await expectFormatted('?#abc\n'); | |||
| expect(await format('? #abc')).toEqual('?#abc\n'); | |||
| }); | |||
|
|
|||
| test('parenthesized `with` expression', async () => { | |||
| await expectFormatted('(x with a = 1);\n'); | |||
There was a problem hiding this comment.
Suggested change
| await expectFormatted('(x with a = 1);\n'); | |
| await expectFormatted('(x with a = 1)\n'); |
These are never followed by a semi, as they are not expressions/statements. Instead they prefix expressions.
There was a problem hiding this comment.
Also maybe test await expectFormatted('(with a = 1)\n'); (and friends).
There was a problem hiding this comment.
Oh I see what you're saying. I'll update the tests so that it includes the following actor, since these cases are assumed to be (invalid) standalone expressions which end in trailing semicolons.
There was a problem hiding this comment.
Yeah, see:
$ rlwrap moc
Motoko compiler (source 0.13.7-202-g68eddf78f-dirty)
> (x with a = 1; b = 2);
stdin:1.22-1.23: syntax error [M0001], unexpected token ';', expected one of token or <phrase> sequence:
<obj_or_class_dec>
async <exp_nest>
<exp_post(ob)> <inst> <exp_nullary(ob)>
This was referenced Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accounts for new syntax in dfinity/motoko#4812.