MDL-31731 Advanced Grading: Marking Guide - prevent negative scores w…

…hen marking users
dfsilva · May 4, 2012 · cfc73aa · cfc73aa
1 parent bea7f96
commit cfc73aa
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/grade/grading/form/guide/lib.php b/grade/grading/form/guide/lib.php
@@ -704,7 +704,8 @@ public function validate_grading_element($elementvalue) {
         foreach ($criteria as $id => $criterion) {
             if (!isset($elementvalue['criteria'][$id]['score'])
                     || $criterion['maxscore'] < $elementvalue['criteria'][$id]['score']
-                    || !is_numeric($elementvalue['criteria'][$id]['score'])) {
+                    || !is_numeric($elementvalue['criteria'][$id]['score'])
+                    || $elementvalue['criteria'][$id]['score'] < 0) {
                 $this->validationerrors[$id]['score'] =  $elementvalue['criteria'][$id]['score'];
             }
         }