Skip to content

Commit

Permalink
s/FIXME/TODO/ to match preferred Go style
Browse files Browse the repository at this point in the history
  • Loading branch information
dgryski committed Aug 10, 2015
1 parent f49e6e0 commit 73a8ad2
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion hokud/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ func topkHandler(w http.ResponseWriter, r *http.Request) {
return
}

// FIXME(dgryski): racey once we move to a ring-buffer?
// TODO(dgryski): racey once we move to a ring-buffer?
t := (int64(epoch) - Epoch0) / WindowSize
if t < 0 || t >= int64(TopKs.Len()) {
http.Error(w, "bad epoch", http.StatusBadRequest)
Expand Down
2 changes: 1 addition & 1 deletion hokud/topk.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package main

// FIXME(dgryski): this is unbounded at the moment -- limit it to 1<<intervals (active) elements
// TODO(dgryski): this is unbounded at the moment -- limit it to 1<<intervals (active) elements

import (
"sync"
Expand Down
8 changes: 4 additions & 4 deletions sketch/sketch.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ type Hokusai struct {

intervals uint

// FIXME(dgryski): rename these to be the same as the paper?
// TODO(dgryski): rename these to be the same as the paper?
itemAggregate []*probably.Sketch // A sketch
liveItems int
timeAggregate []*probably.Sketch // M sketch
Expand Down Expand Up @@ -74,7 +74,7 @@ func (h *Hokusai) Add(epoch int64, s string, count uint32) {
for k := 1; k < l; k++ {
// itemAggregation[t] is the data array for time t
sk := h.itemAggregate[ln-1<<uint(k)]
// FIXME(dgryski): can we avoid this check by be smarter about loop bounds?
// TODO(dgryski): can we avoid this check by be smarter about loop bounds?
if sk != nil {
sk.Compress()
}
Expand All @@ -92,7 +92,7 @@ func (h *Hokusai) Add(epoch int64, s string, count uint32) {
m := h.sk.Clone()
for j := 0; j < l; j++ {
if j > int(h.intervals) {
// FIXME(dgryski): could be smarter here, but it's O(log log(T)), so I'm not worried about it
// TODO(dgryski): could be smarter here, but it's O(log log(T)), so I'm not worried about it
if j < len(h.timeAggregate) {
h.timeAggregate[j] = nil
}
Expand All @@ -119,7 +119,7 @@ func (h *Hokusai) Add(epoch int64, s string, count uint32) {
for j := 1; j < l; j++ {

if j > int(h.intervals) {
// FIXME(dgryski): could be smarter here, but it's O(log log(T)), so I'm not worried about it
// TODO(dgryski): could be smarter here, but it's O(log log(T)), so I'm not worried about it
if j < len(h.itemtimeAggregate) {
h.itemtimeAggregate[j] = nil
}
Expand Down

0 comments on commit 73a8ad2

Please sign in to comment.