lib/rstp: More robust thread safety.

Current code expects there to be a single thread that is responsible
for creating rstp and creating and deleting rstp_port objects.  rstp
objects are also deleted from other threads, as managed by reference
counting.

rstp port objects are not reference counted, which means that
references to rstp ports may only be held while holding the rstp
mutex, or by the thread that creates and deletes them.

This patch adds reference counting to RSTP ports, which allows ports
to be passed from ofproto-dpif to ofproto-dpif-xlate without using the
RSTP port number.  This simplifies RSTP port reconfiguration, as the
port need not be resynchronized with xlate if just the port number
changes.  This also avoids lookups on the processing of RSTP BPDUs.

This patch also:

1. Exposes the rstp mutex so that related thread safety annotations
   can be used also within rstp-state-machines.c.

2. Internal variants of most setter an getter functions are defined,
   suffixed with two underscores.  These are annotated to be callable
   only when the mutex is held.

3. Port setters were only called in a specific pattern.  The new external
   port setter combines them in a single rspt_port_set() function.

Signed-off-by: Jarno Rajahalme <[email protected]>
Acked-by: Daniele Venturino <[email protected]>

lib/rstp-state-machines.h

@@ -33,10 +33,14 @@
 #include "rstp-common.h"
 
 /* Methods called by the Forwarding Layer, through functions of rstp.h. */
-int move_rstp(struct rstp *);
-void decrease_rstp_port_timers(struct rstp *);
-void process_received_bpdu(struct rstp_port *, const void *, size_t);
+int move_rstp__(struct rstp *)
+    OVS_REQUIRES(rstp_mutex);
+void decrease_rstp_port_timers__(struct rstp *)
+    OVS_REQUIRES(rstp_mutex);
+void process_received_bpdu__(struct rstp_port *, const void *, size_t)
+    OVS_REQUIRES(rstp_mutex);
 
-void updt_roles_tree(struct rstp *);
+void updt_roles_tree__(struct rstp *)
+    OVS_REQUIRES(rstp_mutex);
 
 #endif /* rstp-state-machines.h */