Skip to content

Commit

Permalink
Fix a member variables initialization order issue
Browse files Browse the repository at this point in the history
Summary:
In MacOS, I got issue with `Footer`'s default constructor, which initialized the magic number with some random number instead of 0.
With investigation, I found we forgot to make the kInvalidTableMagicNumber to be static. As a result, kInvalidTableMagicNumber was assgined to `table_magic_number_` before it is initialized (which will be populated with random number).

Test Plan: passed current unit tests; also passed the unit tests for the incoming diff which used the default footer.

Reviewers: yhchiang

CC: leveldb

Differential Revision: https://reviews.facebook.net/D16077
  • Loading branch information
liukai committed Feb 11, 2014
1 parent 3304266 commit aa734ce
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion table/format.h
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ class Footer {
kEncodedLength = 2 * BlockHandle::kMaxEncodedLength + 8
};

const uint64_t kInvalidTableMagicNumber = 0;
static const uint64_t kInvalidTableMagicNumber = 0;

private:
// Set the table_magic_number only when it was not previously
Expand Down

0 comments on commit aa734ce

Please sign in to comment.