Remove closing tag in form tag's extra hidden fields

The fields returned from a RequestDataValueProcessor are now written as hidden fields without a closing tag. Before: <input type="hidden" name="xxx" value="yyy"></input> After: <input type="hidden" name="xxx" value="yyy" /> Issue: SPR-10103
dharkness · Jan 8, 2013 · c7d0054 · c7d0054
1 parent 2ac4a8c
commit c7d0054
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/spring-webmvc/src/main/java/org/springframework/web/servlet/tags/form/FormTag.java b/spring-webmvc/src/main/java/org/springframework/web/servlet/tags/form/FormTag.java
@@ -469,8 +469,8 @@ private void writeHiddenFields(Map<String, String> hiddenFields) throws JspExcep
 		if (hiddenFields != null) {
 			for (String name : hiddenFields.keySet()) {
 				this.tagWriter.appendValue("<input type=\"hidden\" ");
-				this.tagWriter.appendValue("name=\"" + name + "\" value=\"" + hiddenFields.get(name) + "\">");
-				this.tagWriter.appendValue("</input>\n");
+				this.tagWriter.appendValue("name=\"" + name + "\" value=\"" + hiddenFields.get(name) + "\" ");
+				this.tagWriter.appendValue("/>\n");
 			}
 		}
 	}

diff --git a/spring-webmvc/src/test/java/org/springframework/web/servlet/tags/form/FormTagTests.java b/spring-webmvc/src/test/java/org/springframework/web/servlet/tags/form/FormTagTests.java
@@ -293,7 +293,7 @@ public void testRequestDataValueProcessorHooks() throws Exception {
 
 		String output = getOutput();
 
-		assertEquals("<input type=\"hidden\" name=\"key\" value=\"value\"></input>", getInputTag(output));
+		assertEquals("<input type=\"hidden\" name=\"key\" value=\"value\" />", getInputTag(output));
 		assertFormTagOpened(output);
 		assertFormTagClosed(output);