Skip to content

Commit

Permalink
Polish formatting
Browse files Browse the repository at this point in the history
Minor formatting polish across that codebase. Primarily fixing
whitespace issues.
  • Loading branch information
philwebb committed Feb 4, 2013
1 parent 0a6da1e commit f464a45
Show file tree
Hide file tree
Showing 114 changed files with 124 additions and 127 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -282,8 +282,8 @@ else if (shadowMatch.neverMatches()) {
return false;
}
else {
// the maybe case
return (beanHasIntroductions || matchesIgnoringSubtypes(shadowMatch) || matchesTarget(shadowMatch, targetClass));
// the maybe case
return (beanHasIntroductions || matchesIgnoringSubtypes(shadowMatch) || matchesTarget(shadowMatch, targetClass));
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ public static boolean makeAdvisorChainAspectJCapableIfNecessary(List<Advisor> ad
*/
private static boolean isAspectJAdvice(Advisor advisor) {
return (advisor instanceof InstantiationModelAwarePointcutAdvisor ||
advisor.getAdvice() instanceof AbstractAspectJAdvice ||
(advisor instanceof PointcutAdvisor &&
advisor.getAdvice() instanceof AbstractAspectJAdvice ||
(advisor instanceof PointcutAdvisor &&
((PointcutAdvisor) advisor).getPointcut() instanceof AspectJExpressionPointcut));
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ class InstantiationModelAwarePointcutAdvisorImpl
private Boolean isAfterAdvice;


public InstantiationModelAwarePointcutAdvisorImpl(AspectJAdvisorFactory af, AspectJExpressionPointcut ajexp,
MetadataAwareAspectInstanceFactory aif, Method method, int declarationOrderInAspect, String aspectName) {
public InstantiationModelAwarePointcutAdvisorImpl(AspectJAdvisorFactory af, AspectJExpressionPointcut ajexp,
MetadataAwareAspectInstanceFactory aif, Method method, int declarationOrderInAspect, String aspectName) {

this.declaredPointcut = ajexp;
this.method = method;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -152,11 +152,11 @@ public abstract class AbstractAutoProxyCreator extends ProxyConfig
* @param order ordering value
*/
public final void setOrder(int order) {
this.order = order;
this.order = order;
}

public final int getOrder() {
return this.order;
return this.order;
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ private void init(Object delegate) {


/**
* Subclasses may need to override this if they want to perform custom
* Subclasses may need to override this if they want to perform custom
* behaviour in around advice. However, subclasses should invoke this
* method, which handles introduced interfaces and forwarding to the target.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ public void testCanGetSourceLocationFromJoinPoint() {
@Override
public void before(Method method, Object[] args, Object target) throws Throwable {
SourceLocation sloc = AbstractAspectJAdvice.currentJoinPoint().getSourceLocation();
assertEquals("Same source location must be returned on subsequent requests", sloc, AbstractAspectJAdvice.currentJoinPoint().getSourceLocation());
assertEquals("Same source location must be returned on subsequent requests", sloc, AbstractAspectJAdvice.currentJoinPoint().getSourceLocation());
assertEquals(TestBean.class, sloc.getWithinType());
try {
sloc.getLine();
Expand Down Expand Up @@ -172,7 +172,7 @@ public void testCanGetStaticPartFromJoinPoint() {
@Override
public void before(Method method, Object[] args, Object target) throws Throwable {
StaticPart staticPart = AbstractAspectJAdvice.currentJoinPoint().getStaticPart();
assertEquals("Same static part must be returned on subsequent requests", staticPart, AbstractAspectJAdvice.currentJoinPoint().getStaticPart());
assertEquals("Same static part must be returned on subsequent requests", staticPart, AbstractAspectJAdvice.currentJoinPoint().getStaticPart());
assertEquals(ProceedingJoinPoint.METHOD_EXECUTION, staticPart.getKind());
assertSame(AbstractAspectJAdvice.currentJoinPoint().getSignature(), staticPart.getSignature());
assertEquals(AbstractAspectJAdvice.currentJoinPoint().getSourceLocation(), staticPart.getSourceLocation());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -940,7 +940,7 @@ public void recordModificationIfSetterArgumentDiffersFromOldValue(JoinPoint jp,
}

// Find the current raw value, by invoking the corresponding setter
Method correspondingGetter = getGetterFromSetter(((MethodSignature) jp.getSignature()).getMethod());
Method correspondingGetter = getGetterFromSetter(((MethodSignature) jp.getSignature()).getMethod());
boolean modified = true;
if (correspondingGetter != null) {
try {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -137,4 +137,4 @@ public Object invoke(Object proxy, Method method, Object[] args) throws Throwabl
AopProxyUtils.proxiedUserInterfaces(proxy);
}

}
}
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ public void testSingletonProxyWithPrototypeTarget() {
assertEquals(10, interceptor.invocationCount);
}


public static interface TestBean {
public void doSomething();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public void testXmlConfig() {
DefaultListableBeanFactory bf = new DefaultListableBeanFactory();
new XmlBeanDefinitionReader(bf).loadBeanDefinitions(CONTEXT);
ITestBean tb = (ITestBean) bf.getBean("proxy");
String name= "tony";
String name = "tony";
tb.setName(name);
// Fires context checks
assertEquals(name, tb.getName());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,4 @@ public void afterReturning(Object o, Method m, Object[] args, Object target) thr
count(m);
}

}
}
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,4 @@ public void afterThrowing(RemoteException ex) throws Throwable {
public void afterThrowing(Method m, Exception ex) throws Throwable {
throw new UnsupportedOperationException("Shouldn't be called");
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,4 @@
@Target(ElementType.TYPE)
public @interface EmptySpringAnnotation {

}
}
2 changes: 1 addition & 1 deletion spring-aop/src/test/java/test/aop/Lockable.java
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,4 @@ public interface Lockable {
void unlock();

boolean locked();
}
}
2 changes: 1 addition & 1 deletion spring-aop/src/test/java/test/aop/PerTargetAspect.java
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,4 @@ public int getOrder() {
public void setOrder(int order) {
this.order = order;
}
}
}
2 changes: 1 addition & 1 deletion spring-aop/src/test/java/test/aop/TwoAdviceAspect.java
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,4 @@ public int returnCallCount(ProceedingJoinPoint pjp) throws Exception {
public void countSet(int newAge) throws Exception {
++totalCalls;
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
* Configurable}.
*
* <p>This configuration class is automatically imported when using the @{@link
* EnableSpringConfigured} annotation. See {@code @EnableSpringConfigured} Javadoc for
* EnableSpringConfigured} annotation. See {@code @EnableSpringConfigured} Javadoc for
* complete usage details.
*
* @author Chris Beams
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,4 @@ protected void setUp() throws Exception {
public void testSpringConfiguredAndAutoProxyUsedTogether() {
; // set up is sufficient to trigger failure if this is going to fail...
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -135,4 +135,4 @@ public Object multiConditionalCacheAndEvict(Object arg1) {
public Object multiUpdate(Object arg1) {
return arg1;
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -67,4 +67,4 @@ public interface CacheableService<T> {
T multiConditionalCacheAndEvict(Object arg1);

T multiUpdate(Object arg1);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -699,7 +699,7 @@ public Object getPropertyValue(String propertyName) throws BeansException {
return nestedBw.getPropertyValue(tokens);
}

private Object getPropertyValue(PropertyTokenHolder tokens) throws BeansException {
private Object getPropertyValue(PropertyTokenHolder tokens) throws BeansException {
String propertyName = tokens.canonicalName;
String actualName = tokens.actualName;
PropertyDescriptor pd = getCachedIntrospectionResults().getPropertyDescriptor(actualName);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
/**
* Marker superinterface indicating that a bean is eligible to be
* notified by the Spring container of a particular framework object
* through a callback-style method. Actual method signature is
* through a callback-style method. Actual method signature is
* determined by individual subinterfaces, but should typically
* consist of just one void-returning method that accepts a single
* argument.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -196,11 +196,11 @@ public void setRequiredParameterValue(boolean requiredParameterValue) {
}

public void setOrder(int order) {
this.order = order;
this.order = order;
}

public int getOrder() {
return this.order;
return this.order;
}

public void setBeanFactory(BeanFactory beanFactory) throws BeansException {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -109,11 +109,11 @@ public void setDestroyAnnotationType(Class<? extends Annotation> destroyAnnotati
}

public void setOrder(int order) {
this.order = order;
this.order = order;
}

public int getOrder() {
return this.order;
return this.order;
}


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -123,11 +123,11 @@ public void setBeanFactory(BeanFactory beanFactory) {
}

public void setOrder(int order) {
this.order = order;
this.order = order;
}

public int getOrder() {
return this.order;
return this.order;
}


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -116,11 +116,11 @@ public class CustomEditorConfigurer implements BeanFactoryPostProcessor, BeanCla


public void setOrder(int order) {
this.order = order;
this.order = order;
}

public int getOrder() {
return this.order;
return this.order;
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public int hashCode() {

@Override
public String toString() {
return '<' + getBeanName() + '>';
return '<' + getBeanName() + '>';
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ public int hashCode() {

@Override
public String toString() {
return '<' + getBeanName() + '>';
return '<' + getBeanName() + '>';
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
* @author Juergen Hoeller
* @since 2.0
*/
public class BeanDefinitionBuilder {
public class BeanDefinitionBuilder {

/**
* Create a new {@code BeanDefinitionBuilder} used to construct a {@link GenericBeanDefinition}.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -888,4 +888,4 @@ public static String[] evaluateAnnotation(Constructor<?> candidate, int paramCou
}
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -736,7 +736,7 @@ protected boolean allowAliasOverriding() {
//---------------------------------------------------------------------

public Object resolveDependency(DependencyDescriptor descriptor, String beanName,
Set<String> autowiredBeanNames, TypeConverter typeConverter) throws BeansException {
Set<String> autowiredBeanNames, TypeConverter typeConverter) throws BeansException {

descriptor.initParameterNameDiscovery(getParameterNameDiscoverer());
if (descriptor.getDependencyType().equals(ObjectFactory.class)) {
Expand All @@ -751,7 +751,7 @@ else if (descriptor.getDependencyType().equals(javaxInjectProviderClass)) {
}

protected Object doResolveDependency(DependencyDescriptor descriptor, Class<?> type, String beanName,
Set<String> autowiredBeanNames, TypeConverter typeConverter) throws BeansException {
Set<String> autowiredBeanNames, TypeConverter typeConverter) throws BeansException {

Object value = getAutowireCandidateResolver().getSuggestedValue(descriptor);
if (value != null) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
* @see #setBeanWiringInfoResolver
* @see ClassNameBeanWiringInfoResolver
*/
public class BeanConfigurerSupport implements BeanFactoryAware, InitializingBean, DisposableBean {
public class BeanConfigurerSupport implements BeanFactoryAware, InitializingBean, DisposableBean {

/** Logger available to subclasses */
protected final Log logger = LogFactory.getLog(getClass());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ else if (systemId.endsWith(XSD_SUFFIX)) {
@Override
public String toString() {
return "EntityResolver delegating " + XSD_SUFFIX + " to " + this.schemaResolver +
" and " + DTD_SUFFIX + " to " + this.dtdResolver;
" and " + DTD_SUFFIX + " to " + this.dtdResolver;
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -148,4 +148,4 @@ private boolean checkName(String name, Collection<ValueHolder> values) {
}
return false;
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ public static DataSource getConfigTimeNonTransactionalDataSource() {
private DataSource nonTransactionalDataSource;


private Map schedulerContextMap;
private Map schedulerContextMap;

private ApplicationContext applicationContext;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -470,4 +470,4 @@ protected Collection<Cache> getCaches() {
return this.caches;
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -89,4 +89,4 @@ private String toString(Method method, String expression) {
sb.append(expression);
return sb.toString();
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -117,4 +117,4 @@ private String toString(Method m) {
sb.append(m.toString());
return sb.toString();
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,4 @@
public enum AdviceMode {
PROXY,
ASPECTJ
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -725,4 +725,4 @@ public Class<?> getDependencyType() {
}
}

}
}
Original file line number Diff line number Diff line change
Expand Up @@ -110,4 +110,4 @@
*/
boolean proxyTargetClass() default false;

}
}
Original file line number Diff line number Diff line change
Expand Up @@ -60,4 +60,4 @@ public interface ImportBeanDefinitionRegistrar {
public void registerBeanDefinitions(
AnnotationMetadata importingClassMetadata, BeanDefinitionRegistry registry);

}
}
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,4 @@ protected void doParse(Element element, BeanDefinitionBuilder builder) {

}

}
}
Loading

0 comments on commit f464a45

Please sign in to comment.