-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ANDROAPP-6535-Bidirectional-relationships-are-created-in-the-oppsite-direction-when-created-from-TO #3928
base: develop
Are you sure you want to change the base?
Conversation
dabf4d7
to
f15a858
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
f15a858
to
50e1cbf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing job!
} | ||
} | ||
return RelationshipModel( | ||
relationship, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a huge data model with a lot of parameters, do you think it would make sense to group some of the parameters to a separate model like RelationshipGeometry, RelationshipProfileDetails, etc...?
tracker/src/main/kotlin/org/dhis2/tracker/relationships/data/RelationshipsRepository.kt
Outdated
Show resolved
Hide resolved
//Here checks if the TEI is the from or to of the relationship | ||
when (teiUid) { | ||
relationship.from()?.trackedEntityInstance()?.trackedEntityInstance() -> { | ||
direction = RelationshipDirection.TO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it would make sense to extract these assignments into separate functions ?
…rogram and then the TEIType Signed-off-by: andresmr <[email protected]>
Signed-off-by: andresmr <[email protected]>
Signed-off-by: andresmr <[email protected]>
Signed-off-by: andresmr <[email protected]>
Signed-off-by: andresmr <[email protected]>
Signed-off-by: andresmr <[email protected]>
Signed-off-by: andresmr <[email protected]>
Signed-off-by: andresmr <[email protected]>
Signed-off-by: andresmr <[email protected]>
…p type Signed-off-by: andresmr <[email protected]>
Signed-off-by: andresmr <[email protected]>
Signed-off-by: andresmr <[email protected]>
50e1cbf
to
74124cc
Compare
Quality Gate passedIssues Measures |
Description
Fix create bidirectional relationship creation
jira issue