[#960183] Ensure we remove ready callbacks when they are called.

dianeboy · Jan 16, 2014 · 7f29250 · 7f29250
1 parent 65a2629
commit 7f29250
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/wrappers/null/popcorn.HTMLNullVideoElement.js b/wrappers/null/popcorn.HTMLNullVideoElement.js
@@ -110,10 +110,11 @@
     self._util.type = "NullVideo";
 
     function addPlayerReadyCallback( callback ) {
-      playerReadyCallbacks.unshift( callback );
+      playerReadyCallbacks.push( callback );
     }
 
-    function onPlayerReady( ) {
+    function onPlayerReady() {
+      var callback;
       playerReady = true;
 
       impl.networkState = self.NETWORK_IDLE;
@@ -128,10 +129,9 @@
       impl.readyState = self.HAVE_ENOUGH_DATA;
       self.dispatchEvent( "canplaythrough" );
 
-      var i = playerReadyCallbacks.length;
-      while( i-- ) {
-        playerReadyCallbacks[ i ]();
-        delete playerReadyCallbacks[ i ];
+      while( playerReadyCallbacks.length ) {
+        callback = playerReadyCallbacks.shift();
+        callback();
       }
 
       // Auto-start if necessary