Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored 'remove_newline_in_middle_of_sentence' #23

Merged
merged 1 commit into from
Nov 7, 2016

Conversation

dmandalinic
Copy link
Contributor

I had an issue where this method ended doing infinite substitutions to the string - resulting in NoMemoryError or computer crash.

It is now refactored. Gemfile and spec_helper.rb were edited per instructions in https://github.com/codeclimate/ruby-test-reporter.

@diasks2
Copy link
Owner

diasks2 commented Nov 7, 2016

Thanks! Nice work!

@diasks2 diasks2 merged commit 0ed124c into diasks2:master Nov 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants