-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use same CMake minimum version in DownloadProject configuration #8611
Conversation
FWIW: https://github.com/model-checking/kani/actions/runs/14191553578/job/39757217581#step:5:55 is an example of such a failing build attempt. |
0c0b5d1
to
45919f8
Compare
If we have a top level requirement why are we (re)specifying the requirement somewhere else? (Not a blocker, but seems a bit odd.) |
That is what I thought as well (and tried the first time around), but then it seems that the use of |
We already have a top-level minimum requirement for CMake >= 3.8, so don't need to specify a lower requirement in a file included from the top level. Having a requirement as low as 2.8.2 broke building on newer version of CMake, which error with "Compatibility with CMake < 3.5 has been removed from CMake." (seen in GitHub runners with Ubuntu 24.04).
45919f8
to
6cbc63b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8611 +/- ##
=========================================
Coverage 79.63% 79.63%
=========================================
Files 1733 1733
Lines 197820 197820
Branches 18173 17968 -205
=========================================
+ Hits 157536 157537 +1
+ Misses 40284 40283 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
We already have a top-level minimum requirement for CMake >= 3.8, so don't need to specify a lower requirement in a file included from the top level.
Having a requirement as low as 2.8.2 broke building on newer version of CMake, which error with "Compatibility with CMake < 3.5 has been removed from CMake." (seen in GitHub runners with Ubuntu 24.04).