Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same CMake minimum version in DownloadProject configuration #8611

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

tautschnig
Copy link
Collaborator

@tautschnig tautschnig commented Apr 1, 2025

We already have a top-level minimum requirement for CMake >= 3.8, so don't need to specify a lower requirement in a file included from the top level.

Having a requirement as low as 2.8.2 broke building on newer version of CMake, which error with "Compatibility with CMake < 3.5 has been removed from CMake." (seen in GitHub runners with Ubuntu 24.04).

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig requested a review from a team as a code owner April 1, 2025 14:24
@tautschnig
Copy link
Collaborator Author

FWIW: https://github.com/model-checking/kani/actions/runs/14191553578/job/39757217581#step:5:55 is an example of such a failing build attempt.

@tautschnig tautschnig force-pushed the cmake-min-version-fix branch from 0c0b5d1 to 45919f8 Compare April 1, 2025 14:29
@tautschnig tautschnig changed the title Remove cmake_minimum_required from DownloadProject configuration Use same CMake minimum version in DownloadProject configuration Apr 1, 2025
@TGWDB
Copy link
Contributor

TGWDB commented Apr 1, 2025

We already have a top-level minimum requirement for CMake >= 3.8, so don't need to specify a lower requirement in a file included from the top level.

If we have a top level requirement why are we (re)specifying the requirement somewhere else? (Not a blocker, but seems a bit odd.)

@tautschnig
Copy link
Collaborator Author

If we have a top level requirement why are we (re)specifying the requirement somewhere else? (Not a blocker, but seems a bit odd.)

That is what I thought as well (and tried the first time around), but then it seems that the use of project in that file requires that cmake_minimum_version be specified in the same file.

We already have a top-level minimum requirement for CMake >= 3.8, so
don't need to specify a lower requirement in a file included from the top
level.

Having a requirement as low as 2.8.2 broke building on newer version of
CMake, which error with "Compatibility with CMake < 3.5 has been removed
from CMake." (seen in GitHub runners with Ubuntu 24.04).
@tautschnig tautschnig force-pushed the cmake-min-version-fix branch from 45919f8 to 6cbc63b Compare April 2, 2025 09:12
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.63%. Comparing base (cd39b3a) to head (6cbc63b).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop    #8611    +/-   ##
=========================================
  Coverage    79.63%   79.63%            
=========================================
  Files         1733     1733            
  Lines       197820   197820            
  Branches     18173    17968   -205     
=========================================
+ Hits        157536   157537     +1     
+ Misses       40284    40283     -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tautschnig tautschnig merged commit fab6710 into diffblue:develop Apr 2, 2025
39 of 40 checks passed
@tautschnig tautschnig deleted the cmake-min-version-fix branch April 2, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants