Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quantifiers with nested statement-expressions #8616

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

qinheping
Copy link
Collaborator

  • Added support for ID_address_of and 'ID_typecastexpressions tofind_base_symbol`.
  • Corrected the multi-path handling in convert_statement_expression---a path not reaching the terminal expression should result in false.
  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link

codecov bot commented Apr 3, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 80.37%. Comparing base (41e9f3d) to head (8b319da).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/ansi-c/goto-conversion/goto_clean_expr.cpp 60.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8616      +/-   ##
===========================================
- Coverage    80.38%   80.37%   -0.01%     
===========================================
  Files         1686     1686              
  Lines       206770   206782      +12     
  Branches        85       85              
===========================================
- Hits        166207   166204       -3     
- Misses       40563    40578      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@qinheping qinheping force-pushed the quantifiers_with_statement_expresssion branch from 4ddfdbf to 25e6c7b Compare April 4, 2025 06:30
@tautschnig tautschnig force-pushed the quantifiers_with_statement_expresssion branch from 25e6c7b to add2b0a Compare April 4, 2025 08:00
- Added support for `ID_address_of` and 'ID_typecast` expressions to `find_base_symbol`.
- Corrected the multi-path handling in
  `convert_statement_expression`---a path not reaching the terminal
expression should be ignored.
@tautschnig tautschnig force-pushed the quantifiers_with_statement_expresssion branch from add2b0a to 8b319da Compare April 4, 2025 08:03
@tautschnig tautschnig enabled auto-merge April 4, 2025 08:03
@tautschnig tautschnig merged commit 16f3ba8 into develop Apr 4, 2025
39 of 41 checks passed
@tautschnig tautschnig deleted the quantifiers_with_statement_expresssion branch April 4, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants