Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.13 with wxPython 3.13 support on Conda-forge #139

Merged
merged 3 commits into from
Dec 7, 2024

Conversation

bobleesj
Copy link
Contributor

@bobleesj bobleesj commented Dec 7, 2024

Closes #138 - support py313 when wxpython supports py313

This issue was created 5 days ago... great timing.

Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.31%. Comparing base (5f0c1b4) to head (8c2b121).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #139   +/-   ##
=======================================
  Coverage   99.31%   99.31%           
=======================================
  Files           6        6           
  Lines         293      293           
=======================================
  Hits          291      291           
  Misses          2        2           

@bobleesj
Copy link
Contributor Author

bobleesj commented Dec 7, 2024

@sbillinge ready for review, tagging @yucongalicechen that our package now supports 3.13

@sbillinge sbillinge merged commit 7f264d2 into diffpy:main Dec 7, 2024
5 checks passed
@sbillinge
Copy link
Contributor

Yeh! ,,🎉

@yucongalicechen please check for and fix warnings that appear in the 3.13 tests

@bobleesj bobleesj deleted the wxpython313 branch December 7, 2024 19:16
@yucongalicechen
Copy link
Collaborator

🥳 Will fix the warnings!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Python 3.13 GitHub CI once wxPython provides Py313 package (currently Python 3.12 is the highest)
3 participants