story/VSPC-217 #351
Open
story/VSPC-217 #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ace content block
…aces-2.0 into story/vspc-171
…t not in the branch
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
jdamerow
requested changes
Jan 9, 2025
| } | ||
|
|
||
| @Override | ||
| public List<ISpace> getAllSpacesPaginated(int page, int pageSize) { |
| if (search != null && !search.trim().isEmpty()) { | ||
| spaces = spaceManager.findByName(search); | ||
| spaces = spaceManager.findByNamePaginated(search, page, PAGE_SIZE); | ||
| hasMore = spaces.size() == PAGE_SIZE; |
There was a problem hiding this comment.
That's not necessarily true, is it? If each page has 10 entries (10 being the number of items on a page), then this would yield true for every page if there are 100 items, even the last one, wouldn't it?
| dataType: 'json', | ||
| success: function(result) { | ||
| console.log("results") | ||
| console.log(result) |
| const space = items[i]; | ||
| if (space.id === spaceId) { | ||
| spaceName = space.name; | ||
| console.log(spaceName) |
| @@ -1179,6 +1209,62 @@ | |||
| }); | |||
| }); | |||
|
|
|||
| function getSpaceById(spaceId, callback) { | |||
| $.ajax({ | |||
| url: [[@{|/staff/spaces/search|}]], | |||
There was a problem hiding this comment.
if you have the space id, you should not have to search spaces. You should get the space by its id.
There was a problem hiding this comment.
but I'ld still have to make an API call do I?
|
|
||
| function getCurrentSpace(blockId) { | ||
| $.ajax({ | ||
| url: [[@{|/staff/spaces/search|}]], |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guidelines for Pull Requests
If you haven't yet read our code review guidelines, please do so, You can find them here.
Please confirm the following by adding an x for each item (turn
[ ]into[x]).Please provide a brief description of your ticket
(you can copy the ticket if it hasn't changed)
Space blocks for slides: The dropdown to select a space for space blocks should be infinite scroll
Anything else the reviewer needs to know?
https://diging.atlassian.net/browse/VSPC-217