This repository has been archived by the owner on Jul 28, 2020. It is now read-only.
Way to disable highlight.js #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgurov
reviewed
Jul 7, 2019
| @@ -1,7 +1,10 @@ | |||
| <script src="//ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script> | |||
| <script src="{{ "js/main.js" | absURL }}"></script> | |||
| {{ if .Site.Params.disableHighlight }} | |||
There was a problem hiding this comment.
if - else could be simplified to
{{ if not .Site.Params.disableHighlight }}
....
{{ end }}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I had the issue myself, I wanted to fix #33
It's working without breaking changes as you have to manually disable highlight.js.
A downside right now is that highlight.js is still copied into /public, but it won't be loaded by the client.
When disabling highlight.js, I noticed that style.css was messing up the code views as well. I also fixed that by only applying the code style in paragraphs.
Copied from #45, as I used the wrong 'compare'.