New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance #41

Open

tomhaber wants to merge 5 commits into dillondaudert:master from tomhaber:improve_performance

tomhaber commented Mar 23, 2021

Improves performance of optimize_embedding by:

better memory locality (use of matrices instead of Vector{Vector})
reduces the number of branches and pow calls
compute the optimization in the precision required (fit_ab causes everything to be Float64). Rather small impact at the moment

Overall, I'm getting almost a factor 2 improvement on larger datasets while avoiding any approximations

tomhaber added 5 commits

March 23, 2021 17:02


          add types to optimize_embedding

75c10ff


          optimize_embedding takes matrices

bb23c3a


          improve performance by removing a pow and branches

86d899a


          change returntype of initialize_embedding to matrix

991504d


          optimize embedding in correct precision

357319c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet