Skip to content

Commit

Permalink
[MINOR] Fix travis builds
Browse files Browse the repository at this point in the history
Each individual commit has a more detailed description of what's being changed and why.

At the moment, Travis builds don't work:

* https://travis-ci.org/mineo/incubator-livy/builds/359324523 - the `sudo pip3 install --upgrade pip "setuptools < 36"` command fails with `sudo: pip3: command not found`.
* fixing that, the `failing the org.apache.rat:apache-rat-plugin:0.12:check` maven goal fails because it sees `.pytest_cache` folders that it doesn't know about (pytest-dev/pytest#3286, failure in https://travis-ci.org/mineo/incubator-livy/jobs/359326261, check the raw log).

This pull request works around the pip3 failures by just using pip as a callable module (possible since Python 3.4) and adding `.pytest_cache` to raw-excludes, as well as showing the contents of `rat.txt` files in the `after_failure` step. I concede that the pip change is more of a workaround, but I don't know how else to fix it and unblock testing.

Running the tests on travis.

Please review https://livy.incubator.apache.org/community/ before opening a pull request.

Author: Wieland Hoffmann <[email protected]>

Closes apache#84 from mineo/rat.
  • Loading branch information
mineo authored and jerryshao committed Apr 9, 2018
1 parent 10373b6 commit 06cfa7b
Showing 2 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions .rat-excludes
Original file line number Diff line number Diff line change
@@ -23,6 +23,7 @@ logs/*
**/derby.log
**/metastore_db/**
**/.eggs/**
**/.pytest_cache/**
**/Gemfile.lock
**/jquery-2.1.1.min.js
docs/**/*.html
6 changes: 3 additions & 3 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -62,9 +62,9 @@ before_install:
- sudo apt-get -y install libkrb5-dev
- sudo apt-get -y remove python-setuptools
- sudo pip2 install --upgrade pip "setuptools < 36"
- sudo pip3 install --upgrade pip "setuptools < 36"
- sudo python3 -m pip install --upgrade pip "setuptools < 36"
- sudo pip2 install codecov cloudpickle
- sudo pip3 install cloudpickle
- sudo python3 -m pip install cloudpickle

install:
- mvn $MVN_FLAG install -Dskip -DskipTests -DskipITs -Dmaven.javadoc.skip=true -B -V
@@ -80,4 +80,4 @@ after_success:
- bash <(curl -s https://codecov.io/bash)

after_failure:
- for log in `find * -name "*.log" -o -name "stderr" -o -name "stdout"`; do echo "=========$log========="; cat $log; done
- for log in `find * -name "*.log" -o -name "stderr" -o -name "stdout" -o -name "rat.txt"`; do echo "=========$log========="; cat $log; done

0 comments on commit 06cfa7b

Please sign in to comment.