Add a code-smell test for iterkeys (ansible#18589)

* Add a code-smell test for iterkeys * Add a message on how to port iterkeys problems and make the grep more robust
dimagi · Dec 14, 2016 · dd46cb7 · dd46cb7
1 parent f789a20
commit dd46cb7
Showing 1 changed file with 18 additions and 0 deletions.
diff --git a/test/sanity/code-smell/no-iterkeys.sh b/test/sanity/code-smell/no-iterkeys.sh
@@ -0,0 +1,18 @@
+#!/bin/sh
+
+ITERKEYS_USERS=$(grep -r -I iterkeys . \
+    --exclude-dir .git \
+    --exclude-dir .tox \
+    --exclude-dir docsite \
+    | grep -v \
+    -e lib/ansible/compat/six/_six.py \
+    -e lib/ansible/module_utils/six.py \
+    -e test/sanity/code-smell/no-iterkeys.sh \
+    -e '^[^:]*:#'
+    )
+
+if [ "${ITERKEYS_USERS}" ]; then
+    echo 'iterkeys has been removed in python3.  Use "for KEY in DICT:" instead'
+    echo "${ITERKEYS_USERS}"
+    exit 1
+fi