Add hint text to QueryRequestUIController #2668
Conversation
| promptHelpButton.visibility = View.VISIBLE | ||
|
|
||
| promptHelpButton.setOnClickListener { | ||
| AlertDialogWrapper.alertDialog(queryRequestActivity, "Hint", hintText) |
There was a problem hiding this comment.
Curios what you think about removing the wrapper and directly calling the StandardAlertDialog.getBasicAlertDialog() method from here.
| @@ -18,6 +18,15 @@ | |||
| android:gravity="center|left" | |||
| android:layout_height="wrap_content" /> | |||
|
|
|||
| <ImageButton | |||
| android:id="@+id/prompt_hint_button" | |||
| android:layout_width="0dp" | |||
There was a problem hiding this comment.
curious what happens if we set the width here to wrap_content and remove layout_weight from below ? I want to avoid using layout_weight for help icon since it may result in unexpected behaviours for different screen sizes. We are setting layout_weight on other views to 1 since we want them to take all the available space but this is not true for help view.
| @@ -20,7 +20,7 @@ | |||
|
|
|||
| <ImageButton | |||
| android:id="@+id/prompt_hint_button" | |||
| android:layout_width="0dp" | |||
| android:layout_width="wrap_content" | |||
| android:layout_height="wrap_content" | |||
| android:layout_weight="0.5" | |||
There was a problem hiding this comment.
we should be able to remove layout_weight if we are able to set the layout_width to wrap_content
| @@ -20,7 +20,7 @@ | |||
|
|
|||
| <ImageButton | |||
| android:id="@+id/prompt_hint_button" | |||
| android:layout_width="0dp" | |||
| android:layout_width="wrap_content" | |||
| android:layout_height="wrap_content" | |||
| android:layout_weight="0.5" | |||
There was a problem hiding this comment.
we should be able to remove layout_weight if we are able to set the layout_width to wrap_content
|
Thanks @Charl1996 . This looks good to me. Although I think we need to do 2 other things to finalise this PR-
|
Thanks! Will do |
| @@ -217,6 +218,12 @@ public void reloadQueryActivityStateTest() { | |||
| EditText patientName = promptsLayout.getChildAt(0).findViewById(R.id.prompt_et); | |||
| assertEquals("francisco", patientName.getText().toString()); | |||
|
|
|||
| ImageButton imageButtonWithoutHint = promptsLayout.getChildAt(0).findViewById(R.id.prompt_hint_button); | |||
| assertEquals(8, imageButtonWithoutHint.getVisibility()); | |||
There was a problem hiding this comment.
We should use the constants from view class here like View.VISIBLE instead of using raw int values, but looks good otherwise.
| val displayData = queryPrompt.display.evaluate() | ||
| val hintText = displayData.hintText ?: return ""; | ||
|
|
||
| return Localizer.processArguments(hintText, arrayOf("")).trim { it <= ' ' } |
There was a problem hiding this comment.
I don't think we need to call Localizer. processArguments here as calling queryPrompt.display.evaluate() should evaluate any localised strings itself.
Summary
Ticket
This PR is to align the webapp and Android app Case Claim UX by adding a hint button on Android which brings up a dialog when clicked, showing the hint/help text configured on HQ, similar to what is seen on the webapps.
When no help/hint text is configured, the hint icon is not shown.
Feature Flag
None specific.
Product Description
The image below shows what the user would have seen before this PR (as well as in the case that no hint text is configured),
When hint text is configured on HQ, the user will see the following button,
Now when the user clicks on the button, a dialog appears with the configured hint text, as seen below,
Safety Assurance
Automated test coverage
Change not covered in automated tests (don't think it's necessary?).
Safety story
Did local testing with and without hint text configured.