Always return a value from _update_or_create_domain_metrics
#35606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise it will TypeError on unpacking `metrics, __` and fail the whole `update_domain_metrics_for_domains` task
orangejenny
approved these changes
Jan 10, 2025
jingcheng16
approved these changes
Jan 10, 2025
Both in the sense of just returning 'metrics', because we never use 'created', and in having one return statement for the function
orangejenny
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise it will TypeError on unpacking
metrics, __and fail the wholeupdate_domain_metrics_for_domainstaskTechnical Summary
Just a bugfix for an in-development feature.
Safety Assurance
Safety story
We're not swallowing any additional errors here, just returning a tuple of something that can be unpacked. The caller,
update_domain_metrics_for_domainsalready accounts formetricspotentially beingNone.Automated test coverage
No tests for this particular return value.
QA Plan
No QA planned.
Rollback instructions
Labels & Review