Create SystemLimit data model #35675
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimagimon
added
the
reindex/migration
gherceg
force-pushed
the
gh/project-limits/data-model
branch
from
1dcd3e5 to
31d5c99
Compare
gherceg
force-pushed
the
gh/project-limits/data-model
branch
from
0f55c33 to
0e9386f
Compare
|
Cal happened to give me drive by thoughts on this, and mentioned that moving feature limits from settings to a model makes it harder to track changes (very fair point). The django admin does track who made changes and when, but that does not include actual values of the limit. We could add the field audit decorator to this model if we are interested in tracking changes over time, which I'm tempted to do. |
That sounds like a good idea. |
orangejenny
reviewed
Jan 27, 2025
last_modified is not needed since it can be determined via audit events
This field is really only intended for extreme circumstances when we want to either increase or decrease a specific domain's limit
|
Sorry for all of the new commits. This is ready for review now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
Technical Summary
Simple SQL table to hold onto limits for features. It is easier to update these via django admin than putting them in settings and having to run cchq commands, so that is the main inspiration for this change. This just introduces the model.
Feature Flag
Safety Assurance
Safety story
Very safe. Just adding a new table.
Automated test coverage
QA Plan
No
Migrations
Rollback instructions
Labels & Review