Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converts web apps specs to ESM #35735

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Converts web apps specs to ESM #35735

merged 2 commits into from
Feb 6, 2025

Conversation

MartinRiese
Copy link
Contributor

Product Description

Just specs

Technical Summary

Keep converting to ESM

Feature Flag

No

Safety Assurance

Safety story

Automated test coverage

all of it

QA Plan

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@MartinRiese MartinRiese marked this pull request as ready for review February 4, 2025 19:59
@dimagimon dimagimon added the Risk: Medium Change affects files that have been flagged as medium risk. label Feb 4, 2025
@MartinRiese MartinRiese enabled auto-merge February 4, 2025 19:59
@MartinRiese MartinRiese merged commit 9fe973a into master Feb 6, 2025
12 of 13 checks passed
@MartinRiese MartinRiese deleted the riese/esm_webapps_2 branch February 6, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orangejenny orangejenny orangejenny approved these changes

@millerdev millerdev Awaiting requested review from millerdev millerdev is a code owner

@AddisonDunn AddisonDunn Awaiting requested review from AddisonDunn AddisonDunn is a code owner

@stephherbers stephherbers Awaiting requested review from stephherbers stephherbers is a code owner

@Robert-Costello Robert-Costello Awaiting requested review from Robert-Costello Robert-Costello is a code owner

@Jtang-1 Jtang-1 Awaiting requested review from Jtang-1 Jtang-1 is a code owner

@nospame nospame Awaiting requested review from nospame nospame is a code owner

Assignees
No one assigned
Labels
Risk: Medium Change affects files that have been flagged as medium risk.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MartinRiese @orangejenny @dimagimon